[PATCH] Recognize OpenBSD ELF

[PATCH] Recognize OpenBSD ELF

[Mark Kettenis]

The attached patch is pretty obvious, so I committed it.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Recognize
	OpenBSD .note.openbsd.ident sections.

Index: osabi.c
===================================================================
RCS file: /cvs/src/src/gdb/osabi.c,v
retrieving revision 1.26
diff -u -p -r1.26 osabi.c
--- osabi.c 21 Jan 2004 23:07:26 -0000 1.26
+++ osabi.c 22 Jan 2004 21:53:56 -0000
@@ -473,6 +473,15 @@ generic_elf_osabi_sniff_abi_tag_sections
       return;
     }
 
+  /* .note.openbsd.ident notes, used by OpenBSD.  */
+  if (strcmp (name, ".note.openbsd.ident") == 0
+      && check_note (abfd, sect, note, "OpenBSD", 4, NT_OPENBSD_IDENT))
+    {
+      /* There is no need to check the version yet.  */
+      *osabi = GDB_OSABI_OPENBSD_ELF;
+      return;
+    }
+
   /* .note.netbsdcore.procinfo notes, used by NetBSD.  */
   if (strcmp (name, ".note.netbsdcore.procinfo") == 0)
     {

Re: [PATCH] Recognize OpenBSD ELF

[cgd]

At Thu, 22 Jan 2004 21:56:59 +0000 (UTC), "Mark Kettenis" wrote:
> The attached patch is pretty obvious, so I committed it.

i do wonder what the intended ordering of stuff in that function is.
looks like previous to this, things were in alphabetical order:

        .note.ABI-tag
        .note.netbsd.ident
        .note.netbsdcore.procinfo


i dunno.  probably not worth thinking about now, but maybe for
somebody who adds the next thing.



cgd

Re: [PATCH] Recognize OpenBSD ELF

[Mark Kettenis]

   From: cgd@broadcom.com
   Date: 22 Jan 2004 14:14:17 -0800

   At Thu, 22 Jan 2004 21:56:59 +0000 (UTC), "Mark Kettenis" wrote:
   > The attached patch is pretty obvious, so I committed it.

   i do wonder what the intended ordering of stuff in that function is.
   looks like previous to this, things were in alphabetical order:

	   .note.ABI-tag
	   .note.netbsd.ident
	   .note.netbsdcore.procinfo

   i dunno.  probably not worth thinking about now, but maybe for
   somebody who adds the next thing.

Well, I added .note.netbsd.ident and .note.netbsdcore.procinfo, so I
can say that the alphabetical order is completely unintentional.  I'd
like to keep the .note.openbsd.ident close to .note.netbsd.ident since
they're almost identical.

Mark