Re: [PATCH] Fix some 64-bit Objective-C bugs

[Daniel Jacobowitz <drow@mvista.com>]

On Fri, Dec 05, 2003 at 10:45:52AM -0700, Adam Fedor wrote:
> 
> On Thursday, December 4, 2003, at 01:10 PM, Ulrich Weigand wrote:
> 
> >
> >
> >ChangeLog:
> >
> >        * eval.c (evaluate_subexp_standard, case OP_OBJC_MSGCALL): Use
> >        CORE_ADDR as type for selectors.  Correct types for GNU run 
> >time
> >        message lookup function to use double indirection.
> >        * objc-lang.c (lookup_child_selector): Use CORE_ADDR as return 
> >type.
> >        * objc-lang.h (lookup_child_selector): Adapt prototype.
> >
> 
> Looks good to me. It also happens to fix a problem I was just getting 
> around to looking at. I'll apply it in a few days if there are no other 
> comments. Thanks for taking the time to look at this.

Hi Adam,

Just reminding you that you never checked in this patch.

> >testsuite/ChangeLog:
> >
> >        * gdb.objc/basicclass.exp: Adapt to fixed return type of 
> >printHi.
> >
> >
> 
> Not sure if I have authority to approve this, unless it's under the 
> obvious rule...

It's obvious.  Also, I think you should be listed as the Objective-C
testsuite maintainer in addition to the Objective-C language
maintainer - does anyone disagree?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer