From: Adam Fedor <fedor@doc.com>
To: "Ulrich Weigand" <weigand@i1.informatik.uni-erlangen.de>
Cc: <gdb-patches@sources.redhat.com>, <uweigand@de.ibm.com>
Subject: Re: [PATCH] Fix some 64-bit Objective-C bugs
Date: Fri, 05 Dec 2003 17:45:00 -0000 [thread overview]
Message-ID: <DE768D37-274A-11D8-A042-000A277AC1A4@doc.com> (raw)
In-Reply-To: <E5F2FFE55E362144876F14CB0AEE713901EB72C5@exchange1.urp.doc.com>
On Thursday, December 4, 2003, at 01:10 PM, Ulrich Weigand wrote:
>
>
> ChangeLog:
>
> * eval.c (evaluate_subexp_standard, case OP_OBJC_MSGCALL): Use
> CORE_ADDR as type for selectors. Correct types for GNU run
> time
> message lookup function to use double indirection.
> * objc-lang.c (lookup_child_selector): Use CORE_ADDR as return
> type.
> * objc-lang.h (lookup_child_selector): Adapt prototype.
>
Looks good to me. It also happens to fix a problem I was just getting
around to looking at. I'll apply it in a few days if there are no other
comments. Thanks for taking the time to look at this.
> testsuite/ChangeLog:
>
> * gdb.objc/basicclass.exp: Adapt to fixed return type of
> printHi.
>
>
Not sure if I have authority to approve this, unless it's under the
obvious rule...
next parent reply other threads:[~2003-12-05 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E5F2FFE55E362144876F14CB0AEE713901EB72C5@exchange1.urp.doc.com>
2003-12-05 17:45 ` Adam Fedor [this message]
2004-01-19 16:33 ` Daniel Jacobowitz
2004-01-19 17:31 ` Adam Fedor
2004-01-19 18:19 ` Andrew Cagney
2004-01-19 18:20 ` Daniel Jacobowitz
2004-01-20 17:42 Ulrich Weigand
-- strict thread matches above, loose matches on Subject: below --
2004-01-19 19:27 Ulrich Weigand
2004-01-19 19:52 ` Andrew Cagney
2003-12-04 20:10 Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE768D37-274A-11D8-A042-000A277AC1A4@doc.com \
--to=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
--cc=uweigand@de.ibm.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox