From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27918 invoked by alias); 19 Jan 2004 16:33:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27908 invoked from network); 19 Jan 2004 16:33:00 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 19 Jan 2004 16:33:00 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AicKa-000504-Uy; Mon, 19 Jan 2004 11:32:52 -0500 Date: Mon, 19 Jan 2004 16:33:00 -0000 From: Daniel Jacobowitz To: Adam Fedor Cc: Ulrich Weigand , gdb-patches@sources.redhat.com, uweigand@de.ibm.com Subject: Re: [PATCH] Fix some 64-bit Objective-C bugs Message-ID: <20040119163252.GC9812@nevyn.them.org> Mail-Followup-To: Adam Fedor , Ulrich Weigand , gdb-patches@sources.redhat.com, uweigand@de.ibm.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00503.txt.bz2 On Fri, Dec 05, 2003 at 10:45:52AM -0700, Adam Fedor wrote: > > On Thursday, December 4, 2003, at 01:10 PM, Ulrich Weigand wrote: > > > > > > >ChangeLog: > > > >        * eval.c (evaluate_subexp_standard, case OP_OBJC_MSGCALL): Use > >        CORE_ADDR as type for selectors.  Correct types for GNU run > >time > >        message lookup function to use double indirection. > >        * objc-lang.c (lookup_child_selector): Use CORE_ADDR as return > >type. > >        * objc-lang.h (lookup_child_selector): Adapt prototype. > > > > Looks good to me. It also happens to fix a problem I was just getting > around to looking at. I'll apply it in a few days if there are no other > comments. Thanks for taking the time to look at this. Hi Adam, Just reminding you that you never checked in this patch. > >testsuite/ChangeLog: > > > >        * gdb.objc/basicclass.exp: Adapt to fixed return type of > >printHi. > > > > > > Not sure if I have authority to approve this, unless it's under the > obvious rule... It's obvious. Also, I think you should be listed as the Objective-C testsuite maintainer in addition to the Objective-C language maintainer - does anyone disagree? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer