From: Mark Kettenis <kettenis@chello.nl>
To: brobecker@gnat.com
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA/patch] handle_inferior_event() extract some code into a separate function
Date: Sat, 03 Jan 2004 12:51:00 -0000 [thread overview]
Message-ID: <200401031251.i03CpAwn025849@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040103115203.GU820@gnat.com> (message from Joel Brobecker on Sat, 3 Jan 2004 12:52:03 +0100)
Date: Sat, 3 Jan 2004 12:52:03 +0100
From: Joel Brobecker <brobecker@gnat.com>
> >This patch implements the first part, which is to extract the code
> >inside the we-stepped-into-a-function if block, and move it to its
> >own function. It's fairly mechanical.
> >
> >The next step will be to change the if condition itself to separate
> >out the targets where the new frame code is used from the ones where
> >the old one is still in use. I will send a patch as soon as this one
> >is reviewed.
>
> M'kay.
Thanks. It's in. Now to the next step...
I get:
gcc -c -g -O2 ... -Werror /home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c
cc1: warnings being treated as errors
/home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c: In function `handle_inferior_event':
/home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c:1337: warning: `real_stop_pc' might be used uninitialized in this function
And as far as I can see, this is a genuine problem :-(. Can you
please back that patch out?
Mark
next prev parent reply other threads:[~2004-01-03 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 14:43 Joel Brobecker
2004-01-02 16:29 ` Andrew Cagney
2004-01-03 11:52 ` Joel Brobecker
2004-01-03 12:51 ` Mark Kettenis [this message]
2004-01-03 13:00 ` Joel Brobecker
2004-01-03 15:01 ` [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function") Joel Brobecker
2004-01-03 15:09 ` Mark Kettenis
2004-01-03 15:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401031251.i03CpAwn025849@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox