From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21248 invoked by alias); 3 Jan 2004 12:51:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21234 invoked from network); 3 Jan 2004 12:51:22 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 3 Jan 2004 12:51:22 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i03CpCAA000534; Sat, 3 Jan 2004 13:51:12 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i03CpBwK025852; Sat, 3 Jan 2004 13:51:11 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i03CpAwn025849; Sat, 3 Jan 2004 13:51:10 +0100 (CET) Date: Sat, 03 Jan 2004 12:51:00 -0000 Message-Id: <200401031251.i03CpAwn025849@elgar.kettenis.dyndns.org> From: Mark Kettenis To: brobecker@gnat.com CC: ac131313@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <20040103115203.GU820@gnat.com> (message from Joel Brobecker on Sat, 3 Jan 2004 12:52:03 +0100) Subject: Re: [RFA/patch] handle_inferior_event() extract some code into a separate function References: <20031219144323.GL826@gnat.com> <3FF59C76.3000902@gnu.org> <20040103115203.GU820@gnat.com> X-SW-Source: 2004-01/txt/msg00048.txt.bz2 Date: Sat, 3 Jan 2004 12:52:03 +0100 From: Joel Brobecker > >This patch implements the first part, which is to extract the code > >inside the we-stepped-into-a-function if block, and move it to its > >own function. It's fairly mechanical. > > > >The next step will be to change the if condition itself to separate > >out the targets where the new frame code is used from the ones where > >the old one is still in use. I will send a patch as soon as this one > >is reviewed. > > M'kay. Thanks. It's in. Now to the next step... I get: gcc -c -g -O2 ... -Werror /home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c cc1: warnings being treated as errors /home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c: In function `handle_inferior_event': /home/kettenis/sandbox/virgin-gdb/src/gdb/infrun.c:1337: warning: `real_stop_pc' might be used uninitialized in this function And as far as I can see, this is a genuine problem :-(. Can you please back that patch out? Mark