From: Joel Brobecker <brobecker@gnat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function")
Date: Sat, 03 Jan 2004 15:18:00 -0000 [thread overview]
Message-ID: <20040103151808.GZ820@gnat.com> (raw)
In-Reply-To: <200401031509.i03F9BXD026205@elgar.kettenis.dyndns.org>
> Here is what I suggest:
>
> 1. A patch to makes it more obvious that this variable is only
> locally used by defining it only inside these if blocks.
> Patch attached.
>
> 2. Send an updated version of the patch I backed out where
> real_stop_pc is local variable to the new function, rather
> than a parameter (that was completely foolish since we don't
> even use the value that was passed and was not set in any case)
>
> Here is the first patch:
>
> 2004-01-03 J. Brobecker <brobecker@gnat.com>
>
> * infrun.c (handle_inferior_event): Move the declaration of
> real_stop_pc inside the if blocks where it is used.
>
> OK to apply? Tested on x86-linux with GCC 3.2.3, no warning, and
> no regression.
>
> Sounds great to me. Consider the other patch pre-approved.
Thanks a lot. The first one has just been committed.
The second one is coming soon.
--
Joel
prev parent reply other threads:[~2004-01-03 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 14:43 [RFA/patch] handle_inferior_event() extract some code into a separate function Joel Brobecker
2004-01-02 16:29 ` Andrew Cagney
2004-01-03 11:52 ` Joel Brobecker
2004-01-03 12:51 ` Mark Kettenis
2004-01-03 13:00 ` Joel Brobecker
2004-01-03 15:01 ` [RFA] infrun.c:handle_inferior_event() tiny simplification (was "Re: [RFA/patch] handle_inferior_event() extract some code into a separate function") Joel Brobecker
2004-01-03 15:09 ` Mark Kettenis
2004-01-03 15:18 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040103151808.GZ820@gnat.com \
--to=brobecker@gnat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox