Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Remove some hardwired assumptions about register sets
Date: Fri, 02 Jan 2004 19:31:00 -0000	[thread overview]
Message-ID: <20040102193146.GA13761@nevyn.them.org> (raw)
In-Reply-To: <3FF5C642.3000504@gnu.org>

On Fri, Jan 02, 2004 at 02:28:02PM -0500, Andrew Cagney wrote:
> >On Mon, Dec 22, 2003 at 06:51:10PM -0700, Fred Fish wrote:
> >
> >>On Tuesday 16 December 2003 23:14, Fred Fish wrote:
> >
> >>> This patch removes some hard coded assumptions about the sizes of the
> >>> various processor specific register sets, and also allows them to be
> >>> of different sizes if necessary.
> >>>
> >>> Comments?
> >
> >>
> >>Except for my own followup, there haven't been any comments about this
> >>patch.
> >>
> >>I propose that if there are no objections by this weekend that the
> >>patch should be checked in, after the previously noted fix is made of
> >>course.
> 
> >I like the patch, for what that's worth.
> 
> Daniel, the patch adds a global variable "num_mips_processor_regs" vis:
> !       tdep->mips_processor_reg_names = mips_irix_reg_names;
> !       num_mips_processor_regs = sizeof (mips_irix_reg_names) / sizeof 
> (char *);
> and that can't be right :-(

Good lord, I'm not paying enough attention.  I'm glad you caught that!

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-02 19:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-17  6:14 Fred Fish
2003-12-17  6:22 ` Fred Fish
2003-12-23  1:51 ` Fred Fish
2003-12-23  2:03   ` Daniel Jacobowitz
2004-01-02 19:28     ` Andrew Cagney
2004-01-02 19:31       ` Daniel Jacobowitz [this message]
2004-01-02 23:12       ` Fred Fish
2004-01-05 15:50         ` Andrew Cagney
2003-12-23 11:30   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040102193146.GA13761@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox