From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29699 invoked by alias); 2 Jan 2004 19:31:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29668 invoked from network); 2 Jan 2004 19:31:47 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 2 Jan 2004 19:31:47 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AcV1O-0003aG-JG for ; Fri, 02 Jan 2004 14:31:46 -0500 Date: Fri, 02 Jan 2004 19:31:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Remove some hardwired assumptions about register sets Message-ID: <20040102193146.GA13761@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200312170614.hBH6Ebtl003033@fred.ninemoons.com> <200312221851.10629.fnf@ninemoons.com> <20031223020339.GA13570@nevyn.them.org> <3FF5C642.3000504@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FF5C642.3000504@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00031.txt.bz2 On Fri, Jan 02, 2004 at 02:28:02PM -0500, Andrew Cagney wrote: > >On Mon, Dec 22, 2003 at 06:51:10PM -0700, Fred Fish wrote: > > > >>On Tuesday 16 December 2003 23:14, Fred Fish wrote: > > > >>> This patch removes some hard coded assumptions about the sizes of the > >>> various processor specific register sets, and also allows them to be > >>> of different sizes if necessary. > >>> > >>> Comments? > > > >> > >>Except for my own followup, there haven't been any comments about this > >>patch. > >> > >>I propose that if there are no objections by this weekend that the > >>patch should be checked in, after the previously noted fix is made of > >>course. > > >I like the patch, for what that's worth. > > Daniel, the patch adds a global variable "num_mips_processor_regs" vis: > ! tdep->mips_processor_reg_names = mips_irix_reg_names; > ! num_mips_processor_regs = sizeof (mips_irix_reg_names) / sizeof > (char *); > and that can't be right :-( Good lord, I'm not paying enough attention. I'm glad you caught that! -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer