From: Roland McGrath <roland@redhat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: Mark Kettenis <m.kettenis@osp.nl>,
Kevin Buettner <kevinb@redhat.com>,
Daniel Jacobowitz <drow@mvista.com>,
Andreas Schwab <schwab@suse.de>,
Scott Bambrough <scottb@netwinder.org>,
gdb-patches@sources.redhat.com
Subject: Re: [PATCH] add-symbol-file-from-memory command
Date: Fri, 03 Oct 2003 22:08:00 -0000 [thread overview]
Message-ID: <200310032208.h93M8MZt021026@magilla.sf.frob.com> (raw)
In-Reply-To: Jim Blandy's message of , 3 October 2003 16:41:40 -0500 <vt2isn6f17v.fsf@zenia.home>
> This is important thing to get right; I'm sorry it wasn't reviewed
> promptly back in May.
The apparent urgency it had then waned, so I stopped pushing on it and we
were all busy with other things. Only now is it really becoming important.
> It doesn't really belong in symfile.c. It's certainly Linux-specific
There is nothing Linux-specific about add-symbol-file-from-memory.
The implementation is ELF-specific, but the concept is not.
> The change itself looks fine. Reviewing it suggested various cleanups
> to symfile.c (say, symbol_file_add_with_addrs_or_offsets should always
> expect an opened BFD, and not take a name), but those are all
> independent of what you're trying to accomplish here, and needn't hold
> it up.
I am happy to do some cleanups while I'm in the area if it's clear what
ought to be done.
next prev parent reply other threads:[~2003-10-03 22:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 4:27 Roland McGrath
2003-10-03 21:41 ` Jim Blandy
2003-10-03 21:45 ` Daniel Jacobowitz
2003-10-03 22:08 ` Roland McGrath [this message]
2003-10-03 22:19 ` Elena Zannoni
2003-10-03 23:00 ` Roland McGrath
2003-10-04 12:57 ` Elena Zannoni
2003-10-04 20:14 ` Roland McGrath
2003-10-07 1:42 ` Andrew Cagney
2003-10-03 22:34 ` Andrew Cagney
2003-10-03 23:02 ` Roland McGrath
2003-10-04 14:39 ` Andrew Cagney
2003-10-06 15:30 ` Jim Blandy
2003-10-06 15:43 ` Daniel Jacobowitz
2003-10-06 19:57 ` Roland McGrath
2003-10-07 23:32 ` Michael Snyder
-- strict thread matches above, loose matches on Subject: below --
2004-04-08 22:38 Roland McGrath
2004-04-15 18:11 ` Jim Blandy
2004-04-15 18:49 ` Andrew Cagney
2004-04-15 21:42 ` Roland McGrath
2004-04-08 20:47 Roland McGrath
2004-04-08 22:13 ` Jim Blandy
2004-04-08 22:28 ` Roland McGrath
2004-04-08 22:32 ` Daniel Jacobowitz
2004-04-08 22:35 ` Andrew Cagney
2004-04-08 22:42 ` Roland McGrath
2004-04-15 18:52 ` Andrew Cagney
2004-02-12 0:34 Roland McGrath
2004-02-13 15:54 ` Andrew Cagney
2004-02-13 19:13 ` Roland McGrath
2004-02-02 3:38 Roland McGrath
2004-02-02 4:06 ` Daniel Jacobowitz
2004-02-02 4:47 ` Roland McGrath
2004-02-02 15:02 ` Daniel Jacobowitz
2004-02-02 23:31 ` Roland McGrath
2004-02-02 23:34 ` Daniel Jacobowitz
2004-02-02 6:19 ` Eli Zaretskii
2004-02-02 7:35 ` Roland McGrath
2004-02-02 17:29 ` Eli Zaretskii
2003-05-20 7:01 Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310032208.h93M8MZt021026@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=kevinb@redhat.com \
--cc=m.kettenis@osp.nl \
--cc=schwab@suse.de \
--cc=scottb@netwinder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox