From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3830 invoked by alias); 3 Oct 2003 22:08:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3821 invoked from network); 3 Oct 2003 22:08:28 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130) by sources.redhat.com with SMTP; 3 Oct 2003 22:08:28 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 85B3D357B; Fri, 3 Oct 2003 15:08:26 -0700 (PDT) Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1]) by magilla.sf.frob.com (8.12.9/8.12.9) with ESMTP id h93M8PN2021030; Fri, 3 Oct 2003 15:08:25 -0700 Received: (from roland@localhost) by magilla.sf.frob.com (8.12.9/8.12.9/Submit) id h93M8MZt021026; Fri, 3 Oct 2003 15:08:22 -0700 Date: Fri, 03 Oct 2003 22:08:00 -0000 Message-Id: <200310032208.h93M8MZt021026@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Jim Blandy Cc: Mark Kettenis , Kevin Buettner , Daniel Jacobowitz , Andreas Schwab , Scott Bambrough , gdb-patches@sources.redhat.com Subject: Re: [PATCH] add-symbol-file-from-memory command In-Reply-To: Jim Blandy's message of , 3 October 2003 16:41:40 -0500 X-Shopping-List: (1) Populous birds (2) Experimental oblivion (3) Incestuous collisions X-SW-Source: 2003-10/txt/msg00063.txt.bz2 > This is important thing to get right; I'm sorry it wasn't reviewed > promptly back in May. The apparent urgency it had then waned, so I stopped pushing on it and we were all busy with other things. Only now is it really becoming important. > It doesn't really belong in symfile.c. It's certainly Linux-specific There is nothing Linux-specific about add-symbol-file-from-memory. The implementation is ELF-specific, but the concept is not. > The change itself looks fine. Reviewing it suggested various cleanups > to symfile.c (say, symbol_file_add_with_addrs_or_offsets should always > expect an opened BFD, and not take a name), but those are all > independent of what you're trying to accomplish here, and needn't hold > it up. I am happy to do some cleanups while I'm in the area if it's clear what ought to be done.