Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrea Michelotti <amichelotti@ipitec.it>
Cc: gdb-patches@sources.redhat.com
Subject: Re: internal error reading f0-f7 registers in arm-elf targets.
Date: Fri, 25 Jul 2003 13:09:00 -0000	[thread overview]
Message-ID: <20030725130931.GB18444@nevyn.them.org> (raw)
In-Reply-To: <3F2115DA.9070507@ipitec.it>

On Fri, Jul 25, 2003 at 01:34:50PM +0200, Andrea Michelotti wrote:
> Eclipse need it.
> -------------------------
> Andrea Michelotti 
> HW/SW Co-Design Manager
> IPITEC (ATMEL)

First of all, _please_ stop posting an entire copy of the ChangeLog
file.  We don't need all 400K.

> Index: arm-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.h,v
> retrieving revision 1.11
> diff -c -p -r1.11 arm-tdep.h
> *** arm-tdep.h	22 Mar 2003 20:39:21 -0000	1.11
> --- arm-tdep.h	25 Jul 2003 11:24:35 -0000
> *************** enum gdb_regnum {
> *** 62,68 ****
>   /* GCC doesn't support long doubles (extended IEEE values).  The FP
>      register virtual size is therefore 64 bits.  Used for documentation
>      purposes and code readability in this header.  */
> ! #define FP_REGISTER_VIRTUAL_SIZE	8
>   
>   /* Status registers are the same size as general purpose registers.
>      Used for documentation purposes and code readability in this
> --- 62,72 ----
>   /* GCC doesn't support long doubles (extended IEEE values).  The FP
>      register virtual size is therefore 64 bits.  Used for documentation
>      purposes and code readability in this header.  */
> ! 
> ! /* generate an internal error in findvar.c */
> ! /* #define FP_REGISTER_VIRTUAL_SIZE	8 */
> ! 
> ! #define FP_REGISTER_VIRTUAL_SIZE	FP_REGISTER_RAW_SIZE


Secondly, just changing the number is hardly correct.  Patches have to
fix the problem, not just hide around it by making an incorrect change;
and the comment is still accurate.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-07-25 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-25 11:33 Andrea Michelotti
2003-07-25 13:09 ` Daniel Jacobowitz [this message]
2003-07-25 13:40   ` Andrea Michelotti
2003-07-27 19:25     ` Andrew Cagney
2003-07-28  8:41       ` Richard Earnshaw
2003-07-28 15:12         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030725130931.GB18444@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=amichelotti@ipitec.it \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox