From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18757 invoked by alias); 25 Jul 2003 13:09:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18746 invoked from network); 25 Jul 2003 13:09:36 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 25 Jul 2003 13:09:36 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19g2KB-0005u8-OF; Fri, 25 Jul 2003 09:09:31 -0400 Date: Fri, 25 Jul 2003 13:09:00 -0000 From: Daniel Jacobowitz To: Andrea Michelotti Cc: gdb-patches@sources.redhat.com Subject: Re: internal error reading f0-f7 registers in arm-elf targets. Message-ID: <20030725130931.GB18444@nevyn.them.org> Mail-Followup-To: Andrea Michelotti , gdb-patches@sources.redhat.com References: <3F2115DA.9070507@ipitec.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F2115DA.9070507@ipitec.it> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00449.txt.bz2 On Fri, Jul 25, 2003 at 01:34:50PM +0200, Andrea Michelotti wrote: > Eclipse need it. > ------------------------- > Andrea Michelotti > HW/SW Co-Design Manager > IPITEC (ATMEL) First of all, _please_ stop posting an entire copy of the ChangeLog file. We don't need all 400K. > Index: arm-tdep.h > =================================================================== > RCS file: /cvs/src/src/gdb/arm-tdep.h,v > retrieving revision 1.11 > diff -c -p -r1.11 arm-tdep.h > *** arm-tdep.h 22 Mar 2003 20:39:21 -0000 1.11 > --- arm-tdep.h 25 Jul 2003 11:24:35 -0000 > *************** enum gdb_regnum { > *** 62,68 **** > /* GCC doesn't support long doubles (extended IEEE values). The FP > register virtual size is therefore 64 bits. Used for documentation > purposes and code readability in this header. */ > ! #define FP_REGISTER_VIRTUAL_SIZE 8 > > /* Status registers are the same size as general purpose registers. > Used for documentation purposes and code readability in this > --- 62,72 ---- > /* GCC doesn't support long doubles (extended IEEE values). The FP > register virtual size is therefore 64 bits. Used for documentation > purposes and code readability in this header. */ > ! > ! /* generate an internal error in findvar.c */ > ! /* #define FP_REGISTER_VIRTUAL_SIZE 8 */ > ! > ! #define FP_REGISTER_VIRTUAL_SIZE FP_REGISTER_RAW_SIZE Secondly, just changing the number is hardly correct. Patches have to fix the problem, not just hide around it by making an incorrect change; and the comment is still accurate. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer