Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: amichelotti@ipitec.it, Daniel Jacobowitz <drow@mvista.com>,
	Richard Earnshaw <rearnsha@arm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: internal error reading f0-f7 registers in arm-elf targets.
Date: Sun, 27 Jul 2003 19:25:00 -0000	[thread overview]
Message-ID: <3F24271D.9040304@redhat.com> (raw)
In-Reply-To: <3F2133D7.8020800@ipitec.it>


> Secondly, just changing the number is hardly correct.  Patches have to
> fix the problem, not just hide around it by making an incorrect change;
> and the comment is still accurate.

Well arm_register_virtual_size() and arm_register_virtual_type() 
disagree, outch!

BTW, see also:
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=1276

I get the feeling that FP_REGISTER_VIRTUAL_SIZE has nothing to do with 
FP_REGISTER_RAW_SIZE and arm_register_virtual_size should return the raw 
value.  Well ok, technically, arm_register_virtual_size, 
arm_register_raw_size and arm_register_virtual_type should all be folded 
into arm_register_type.

Looking at FP_REGISTER_VIRTUAL_SIZE that really only comes into play 
when the Arm doesn't even have H/W floating point registers.  See 
arm-linux-tdep.c where it pushes on a double fp value on the stack.

On the other hand, the Arm prologue analysis code, appears to assume 
that those registers are always 12 bytes.  Look for:
/* stfe f?, [sp, -#c]! */
	store floating point extended (i.e. 12 bytes)
/* sfmfd f0, 4, [sp!] */
	store 12 byte floating point registers
so it things 12 byte floats are stored.

Andrew



  reply	other threads:[~2003-07-27 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-25 11:33 Andrea Michelotti
2003-07-25 13:09 ` Daniel Jacobowitz
2003-07-25 13:40   ` Andrea Michelotti
2003-07-27 19:25     ` Andrew Cagney [this message]
2003-07-28  8:41       ` Richard Earnshaw
2003-07-28 15:12         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F24271D.9040304@redhat.com \
    --to=ac131313@redhat.com \
    --cc=amichelotti@ipitec.it \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox