From: Mark Kettenis <kettenis@chello.nl>
To: schwab@suse.de
Cc: mludvig@suse.cz, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Re: Analyzing AMD64 corefiles on i386
Date: Wed, 09 Jul 2003 13:40:00 -0000 [thread overview]
Message-ID: <200307091340.h69De7Rx023816@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <je65mbrk03.fsf@sykes.suse.de> (message from Andreas Schwab on Wed, 09 Jul 2003 13:56:44 +0200)
From: Andreas Schwab <schwab@suse.de>
Date: Wed, 09 Jul 2003 13:56:44 +0200
Michal Ludvig <mludvig@suse.cz> writes:
|> 2003-07-09 Michal Ludvig <mludvig@suse.cz>
|>
|> * x86-64-linux-nat.c (regmap, supply_gregset, fill_gregset):
|> Moved to x86-64-linux-tdep.c.
|> * x86-64-linux-tdep.c (regmap, supply_gregset, fill_gregset):
|> Moved from x86-64-linux-nat.c.
Hmm, m68klinux-nat.c has this comment:
/* Note both m68k-tdep.c and m68klinux-nat.c contain definitions
for supply_gregset and supply_fpregset. The definitions
in m68k-tdep.c are valid if USE_PROC_FS is defined. Otherwise,
the definitions in m68klinux-nat.c will be used. This is a
bit of a hack. The supply_* routines do not belong in
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
*_tdep.c files. But, there are several lynx ports that currently
^^^^^^^^^^^^^^
depend on these definitions. */
What's the current wisdom about that?
It's still true. If register conversion functions are implemented in
*-tdep.c files, they should not be named supply_gregset/fill_gregset.
Mark
next prev parent reply other threads:[~2003-07-09 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3F0ABC85.1080700@suse.cz>
[not found] ` <200307081445.h68EjBWJ000503@elgar.kettenis.dyndns.org>
2003-07-09 11:03 ` Michal Ludvig
2003-07-09 11:56 ` Andreas Schwab
2003-07-09 13:40 ` Mark Kettenis [this message]
2003-07-09 13:38 ` Mark Kettenis
2003-07-09 18:08 ` Daniel Jacobowitz
2003-07-09 19:52 ` Andrew Cagney
2003-07-09 21:46 ` Mark Kettenis
2003-07-10 10:05 ` Michal Ludvig
2003-07-14 19:26 ` Mark Kettenis
2003-07-15 11:34 ` Michal Ludvig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307091340.h69De7Rx023816@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=mludvig@suse.cz \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox