From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23423 invoked by alias); 9 Jul 2003 13:40:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23021 invoked from network); 9 Jul 2003 13:40:08 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 9 Jul 2003 13:40:08 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h69De78E002549; Wed, 9 Jul 2003 15:40:07 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h69De7Zb023819; Wed, 9 Jul 2003 15:40:07 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h69De7Rx023816; Wed, 9 Jul 2003 15:40:07 +0200 (CEST) Date: Wed, 09 Jul 2003 13:40:00 -0000 Message-Id: <200307091340.h69De7Rx023816@elgar.kettenis.dyndns.org> From: Mark Kettenis To: schwab@suse.de CC: mludvig@suse.cz, gdb-patches@sources.redhat.com In-reply-to: (message from Andreas Schwab on Wed, 09 Jul 2003 13:56:44 +0200) Subject: Re: [RFA] Re: Analyzing AMD64 corefiles on i386 References: <3F0ABC85.1080700@suse.cz> <200307081445.h68EjBWJ000503@elgar.kettenis.dyndns.org> <3F0BF66A.3080203@suse.cz> X-SW-Source: 2003-07/txt/msg00169.txt.bz2 From: Andreas Schwab Date: Wed, 09 Jul 2003 13:56:44 +0200 Michal Ludvig writes: |> 2003-07-09 Michal Ludvig |> |> * x86-64-linux-nat.c (regmap, supply_gregset, fill_gregset): |> Moved to x86-64-linux-tdep.c. |> * x86-64-linux-tdep.c (regmap, supply_gregset, fill_gregset): |> Moved from x86-64-linux-nat.c. Hmm, m68klinux-nat.c has this comment: /* Note both m68k-tdep.c and m68klinux-nat.c contain definitions for supply_gregset and supply_fpregset. The definitions in m68k-tdep.c are valid if USE_PROC_FS is defined. Otherwise, the definitions in m68klinux-nat.c will be used. This is a bit of a hack. The supply_* routines do not belong in ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ *_tdep.c files. But, there are several lynx ports that currently ^^^^^^^^^^^^^^ depend on these definitions. */ What's the current wisdom about that? It's still true. If register conversion functions are implemented in *-tdep.c files, they should not be named supply_gregset/fill_gregset. Mark