From: fnf@intrinsity.com (Fred Fish)
To: ac131313@redhat.com (Andrew Cagney)
Cc: fnf@intrinsity.com (Fred Fish), gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Don't clobber info->mach in gdb_print_insn_mips
Date: Tue, 24 Jun 2003 00:51:00 -0000 [thread overview]
Message-ID: <20030624005110.4C00F2F2F2C@beeville.vert.intrinsity.com> (raw)
In-Reply-To: <3EF772BD.3020100@redhat.com> from "Andrew Cagney" at Jun 23, 2003 05:35:57 PM
> So you're ok if I delete that bit of gdb_print_insn_mips?
Works for me, though I assume that it was put there for a
reason. Perhaps a better fix is something like:
if (proc_desc)
{
if (pc_is_mips16 (PROC_LOW_ADDR (proc_desc))
info->mach = bfd_mach_mips16;
}
else
{
if (pc_is_mips16 (memaddr))
info->mach = bfd_mach_mips16;
}
which would leave info->mach alone unless pc_is_mips16 is true.
-Fred
next prev parent reply other threads:[~2003-06-24 0:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 14:14 Fred Fish
2003-06-23 20:38 ` Andrew Cagney
2003-06-23 21:39 ` Fred Fish
2003-06-23 21:40 ` Andrew Cagney
2003-06-24 0:51 ` Fred Fish [this message]
2003-06-25 21:47 ` Andrew Cagney
2003-06-26 18:00 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030624005110.4C00F2F2F2C@beeville.vert.intrinsity.com \
--to=fnf@intrinsity.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox