Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: fnf@intrinsity.com (Fred Fish)
To: gdb-patches@sources.redhat.com
Cc: fnf@intrinsity.com (Fred Fish)
Subject: [PATCH] Don't clobber info->mach in gdb_print_insn_mips
Date: Mon, 23 Jun 2003 14:14:00 -0000	[thread overview]
Message-ID: <20030623133919.2C2E92F2C23@beeville.vert.intrinsity.com> (raw)

I updated to the latest CVS gdb over the weekend and afterwards my
mipsisa32-intrinsity-elf target would no longer disassemble
coprocessor 2 instructions correctly.  I tracked it down to the
info->mach field being clobbered by gdb_print_insn_mips.  The attached
patch fixes it, though I'm not sure if this is the correct solution.

Note that mipsisa32-intrinsity-elf is not yet a supported target
configuration as it is a work in progress and the patches have not
been submitted yet.  But mipsisa32-unknown-elf has a similar problem.

-Fred


2003-06-23  Fred Fish  <fnf@intrinsity.com>

	* mips-tdep.c (gdb_print_insn_mips): Don't clobber a previously
	set value of info->mach.


Index: mips-tdep.c
===================================================================
RCS file: /mips/newtools/fsf/gdb/gdb/mips-tdep.c,v
retrieving revision 1.20
diff -c -r1.20 mips-tdep.c
*** mips-tdep.c	2003/06/23 02:13:09	1.20
--- mips-tdep.c	2003/06/23 13:33:02
***************
*** 5279,5288 ****
       guess that if the address passed in is odd, it's 16-bits.  */
    if (proc_desc)
      info->mach = pc_is_mips16 (PROC_LOW_ADDR (proc_desc)) ?
!       bfd_mach_mips16 : 0;
    else
      info->mach = pc_is_mips16 (memaddr) ?
!       bfd_mach_mips16 : 0;
  
    /* Round down the instruction address to the appropriate boundary.  */
    memaddr &= (info->mach == bfd_mach_mips16 ? ~1 : ~3);
--- 5279,5288 ----
       guess that if the address passed in is odd, it's 16-bits.  */
    if (proc_desc)
      info->mach = pc_is_mips16 (PROC_LOW_ADDR (proc_desc)) ?
!       bfd_mach_mips16 : info->mach;
    else
      info->mach = pc_is_mips16 (memaddr) ?
!       bfd_mach_mips16 : info->mach;
  
    /* Round down the instruction address to the appropriate boundary.  */
    memaddr &= (info->mach == bfd_mach_mips16 ? ~1 : ~3);


             reply	other threads:[~2003-06-23 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-23 14:14 Fred Fish [this message]
2003-06-23 20:38 ` Andrew Cagney
2003-06-23 21:39   ` Fred Fish
2003-06-23 21:40     ` Andrew Cagney
2003-06-24  0:51       ` Fred Fish
2003-06-25 21:47         ` Andrew Cagney
2003-06-26 18:00           ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030623133919.2C2E92F2C23@beeville.vert.intrinsity.com \
    --to=fnf@intrinsity.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox