From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20424 invoked by alias); 24 Jun 2003 00:51:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20286 invoked from network); 24 Jun 2003 00:51:12 -0000 Received: from unknown (HELO mailhost.intrinsity.com) (208.246.32.130) by sources.redhat.com with SMTP; 24 Jun 2003 00:51:12 -0000 Received: from victoria.intrinsity.com (victoria.eng.intrinsity.com [192.168.1.29]) by mailhost.intrinsity.com (Postfix) with ESMTP id 2F8423F385; Mon, 23 Jun 2003 19:51:11 -0500 (CDT) Received: from beeville.vert.intrinsity.com (beeville.vert.intrinsity.com [192.168.3.48]) by victoria.intrinsity.com (Postfix) with ESMTP id B300C4586C; Mon, 23 Jun 2003 19:51:10 -0500 (CDT) Received: by beeville.vert.intrinsity.com (Postfix, from userid 621) id 4C00F2F2F2C; Tue, 24 Jun 2003 00:51:10 +0000 (UTC) Subject: Re: [PATCH] Don't clobber info->mach in gdb_print_insn_mips To: ac131313@redhat.com (Andrew Cagney) Date: Tue, 24 Jun 2003 00:51:00 -0000 Cc: fnf@intrinsity.com (Fred Fish), gdb-patches@sources.redhat.com Reply-To: fnf@intrinsity.com (Fred Fish) In-Reply-To: <3EF772BD.3020100@redhat.com> from "Andrew Cagney" at Jun 23, 2003 05:35:57 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20030624005110.4C00F2F2F2C@beeville.vert.intrinsity.com> From: fnf@intrinsity.com (Fred Fish) X-SW-Source: 2003-06/txt/msg00747.txt.bz2 > So you're ok if I delete that bit of gdb_print_insn_mips? Works for me, though I assume that it was put there for a reason. Perhaps a better fix is something like: if (proc_desc) { if (pc_is_mips16 (PROC_LOW_ADDR (proc_desc)) info->mach = bfd_mach_mips16; } else { if (pc_is_mips16 (memaddr)) info->mach = bfd_mach_mips16; } which would leave info->mach alone unless pc_is_mips16 is true. -Fred