From: Mark Kettenis <kettenis@chello.nl>
To: ac131313@redhat.com
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [cagney_convert-20030606-branch] Add value to REGISTER_TO_VALUE et.al.
Date: Sun, 08 Jun 2003 22:51:00 -0000 [thread overview]
Message-ID: <200306082250.h58Mow31022350@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <3EE3B455.7080902@redhat.com> (message from Andrew Cagney on Sun, 08 Jun 2003 18:10:29 -0400)
Date: Sun, 08 Jun 2003 18:10:29 -0400
From: Andrew Cagney <ac131313@redhat.com>
Ok, I've changed the branch to:
> The ``obvious'' interfaces were:
>
> register_to_value (frame, regnum, type, buffer)
> value_to_register (frame, regnum, type, buffer)
And what do these functions do if the register is unavailable in a
certain frame? That shouldn't happen if we have complete debug
information, but unfortunately we almost certainly don't have that.
Should this be reported to the user or not? Should we set
VALUE_OPTIMIZED_OUT, just as we do for registers that don't need
conversion? If so, we probably need a return value that indicates
whether the conversion was successfull.
> but that tripped up on something (now what ...?). Dig dig.
> Notice how, to preserve existing behavior,
> legacy_register_to_value saves the location based on what
> frame_register returns. We'd have to switch to
> lval_reg_frame_relative.
And this time it appears to be going better. I'll try to attribute it
to VALUE_FRAME_ID and the use of put_frame_register (neither of which I
did last time).
Great!
Mark
next prev parent reply other threads:[~2003-06-08 22:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 19:38 [wip/rfc] Merge REGISTER_TO_VALUE and REGISTER_TO_TYPE Andrew Cagney
2003-06-04 21:45 ` Mark Kettenis
2003-06-04 23:05 ` Andrew Cagney
2003-06-06 18:12 ` [cagney_convert-20030606-branch] Add value to REGISTER_TO_VALUE et.al Andrew Cagney
2003-06-08 16:43 ` Mark Kettenis
2003-06-08 17:15 ` Andrew Cagney
2003-06-08 22:11 ` Andrew Cagney
2003-06-08 22:51 ` Mark Kettenis [this message]
2003-06-09 0:22 ` Andrew Cagney
2003-06-09 9:35 ` Mark Kettenis
2003-06-09 14:38 ` Andrew Cagney
2003-06-09 9:38 ` Mark Kettenis
2003-06-09 14:20 ` Andrew Cagney
2003-06-09 17:43 ` Mark Kettenis
2003-06-09 10:26 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306082250.h58Mow31022350@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox