From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28664 invoked by alias); 8 Jun 2003 22:51:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28564 invoked from network); 8 Jun 2003 22:51:06 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 8 Jun 2003 22:51:06 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h58MowvW000347; Mon, 9 Jun 2003 00:50:58 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h58Mowmc022353; Mon, 9 Jun 2003 00:50:58 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h58Mow31022350; Mon, 9 Jun 2003 00:50:58 +0200 (CEST) Date: Sun, 08 Jun 2003 22:51:00 -0000 Message-Id: <200306082250.h58Mow31022350@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ac131313@redhat.com CC: ac131313@redhat.com, gdb-patches@sources.redhat.com In-reply-to: <3EE3B455.7080902@redhat.com> (message from Andrew Cagney on Sun, 08 Jun 2003 18:10:29 -0400) Subject: Re: [cagney_convert-20030606-branch] Add value to REGISTER_TO_VALUE et.al. References: <3EDE4A9E.70403@redhat.com> <8665nl34ao.fsf@elgar.kettenis.dyndns.org> <3EE0D987.6030207@redhat.com> <200306081643.h58GhiTr048427@elgar.kettenis.dyndns.org> <3EE36F28.9000104@redhat.com> <3EE3B455.7080902@redhat.com> X-SW-Source: 2003-06/txt/msg00287.txt.bz2 Date: Sun, 08 Jun 2003 18:10:29 -0400 From: Andrew Cagney Ok, I've changed the branch to: > The ``obvious'' interfaces were: > > register_to_value (frame, regnum, type, buffer) > value_to_register (frame, regnum, type, buffer) And what do these functions do if the register is unavailable in a certain frame? That shouldn't happen if we have complete debug information, but unfortunately we almost certainly don't have that. Should this be reported to the user or not? Should we set VALUE_OPTIMIZED_OUT, just as we do for registers that don't need conversion? If so, we probably need a return value that indicates whether the conversion was successfull. > but that tripped up on something (now what ...?). Dig dig. > Notice how, to preserve existing behavior, > legacy_register_to_value saves the location based on what > frame_register returns. We'd have to switch to > lval_reg_frame_relative. And this time it appears to be going better. I'll try to attribute it to VALUE_FRAME_ID and the use of put_frame_register (neither of which I did last time). Great! Mark