[PATCH/RFA] Fix size_t related problems in dwarf2loc.c

[PATCH/RFA] Fix size_t related problems in dwarf2loc.c

[Mark Kettenis]

I got a few warnings on hppa1.1-hp-hpux-11.00.  Anyway, a size_t isn't
necessarily the same as an int.  OK to apply?

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* dwarf2loc.c (find_location_expression): Change type of second
	argument to `size_t *'.
	(loclist_read_variable, loclist_tracepoint_var_ref): Use size_t
	for size variable.

Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.7
diff -u -p -r1.7 dwarf2loc.c
--- dwarf2loc.c 22 Apr 2003 23:18:26 -0000 1.7
+++ dwarf2loc.c 18 May 2003 10:24:39 -0000
@@ -50,7 +50,7 @@
 
 static char *
 find_location_expression (struct dwarf2_loclist_baton *baton,
-			  int *locexpr_length, CORE_ADDR pc)
+			  size_t *locexpr_length, CORE_ADDR pc)
 {
   CORE_ADDR base_address = baton->base_address;
   CORE_ADDR low, high;
@@ -448,7 +448,7 @@ loclist_read_variable (struct symbol *sy
   struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
   struct value *val;
   unsigned char *data;
-  int size;
+  size_t size;
 
   data = find_location_expression (dlbaton, &size,
 				   frame ? get_frame_pc (frame) : 0);
@@ -490,7 +490,7 @@ loclist_tracepoint_var_ref (struct symbo
 {
   struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
   unsigned char *data;
-  int size;
+  size_t size;
 
   data = find_location_expression (dlbaton, &size, ax->scope);
   if (data == NULL)

Re: [PATCH/RFA] Fix size_t related problems in dwarf2loc.c

[Daniel Jacobowitz]

On Sun, May 18, 2003 at 12:26:01PM +0200, Mark Kettenis wrote:
> I got a few warnings on hppa1.1-hp-hpux-11.00.  Anyway, a size_t isn't
> necessarily the same as an int.  OK to apply?

I think this counts as an obvious fix...

> 
> Mark
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* dwarf2loc.c (find_location_expression): Change type of second
> 	argument to `size_t *'.
> 	(loclist_read_variable, loclist_tracepoint_var_ref): Use size_t
> 	for size variable.
> 
> Index: dwarf2loc.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
> retrieving revision 1.7
> diff -u -p -r1.7 dwarf2loc.c
> --- dwarf2loc.c 22 Apr 2003 23:18:26 -0000 1.7
> +++ dwarf2loc.c 18 May 2003 10:24:39 -0000
> @@ -50,7 +50,7 @@
>  
>  static char *
>  find_location_expression (struct dwarf2_loclist_baton *baton,
> -			  int *locexpr_length, CORE_ADDR pc)
> +			  size_t *locexpr_length, CORE_ADDR pc)
>  {
>    CORE_ADDR base_address = baton->base_address;
>    CORE_ADDR low, high;
> @@ -448,7 +448,7 @@ loclist_read_variable (struct symbol *sy
>    struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
>    struct value *val;
>    unsigned char *data;
> -  int size;
> +  size_t size;
>  
>    data = find_location_expression (dlbaton, &size,
>  				   frame ? get_frame_pc (frame) : 0);
> @@ -490,7 +490,7 @@ loclist_tracepoint_var_ref (struct symbo
>  {
>    struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
>    unsigned char *data;
> -  int size;
> +  size_t size;
>  
>    data = find_location_expression (dlbaton, &size, ax->scope);
>    if (data == NULL)
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [PATCH/RFA] Fix size_t related problems in dwarf2loc.c

[Mark Kettenis]

   Date: Sun, 18 May 2003 11:11:18 -0400
   From: Daniel Jacobowitz <drow@mvista.com>

   On Sun, May 18, 2003 at 12:26:01PM +0200, Mark Kettenis wrote:
   > I got a few warnings on hppa1.1-hp-hpux-11.00.  Anyway, a size_t isn't
   > necessarily the same as an int.  OK to apply?

   I think this counts as an obvious fix...

Great,

Checked in.

Mark