Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Fix size_t related problems in dwarf2loc.c
Date: Sun, 18 May 2003 15:11:00 -0000	[thread overview]
Message-ID: <20030518151118.GA17081@nevyn.them.org> (raw)
In-Reply-To: <200305181026.h4IAQ1Kv031019@elgar.kettenis.dyndns.org>

On Sun, May 18, 2003 at 12:26:01PM +0200, Mark Kettenis wrote:
> I got a few warnings on hppa1.1-hp-hpux-11.00.  Anyway, a size_t isn't
> necessarily the same as an int.  OK to apply?

I think this counts as an obvious fix...

> 
> Mark
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* dwarf2loc.c (find_location_expression): Change type of second
> 	argument to `size_t *'.
> 	(loclist_read_variable, loclist_tracepoint_var_ref): Use size_t
> 	for size variable.
> 
> Index: dwarf2loc.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
> retrieving revision 1.7
> diff -u -p -r1.7 dwarf2loc.c
> --- dwarf2loc.c 22 Apr 2003 23:18:26 -0000 1.7
> +++ dwarf2loc.c 18 May 2003 10:24:39 -0000
> @@ -50,7 +50,7 @@
>  
>  static char *
>  find_location_expression (struct dwarf2_loclist_baton *baton,
> -			  int *locexpr_length, CORE_ADDR pc)
> +			  size_t *locexpr_length, CORE_ADDR pc)
>  {
>    CORE_ADDR base_address = baton->base_address;
>    CORE_ADDR low, high;
> @@ -448,7 +448,7 @@ loclist_read_variable (struct symbol *sy
>    struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
>    struct value *val;
>    unsigned char *data;
> -  int size;
> +  size_t size;
>  
>    data = find_location_expression (dlbaton, &size,
>  				   frame ? get_frame_pc (frame) : 0);
> @@ -490,7 +490,7 @@ loclist_tracepoint_var_ref (struct symbo
>  {
>    struct dwarf2_loclist_baton *dlbaton = SYMBOL_LOCATION_BATON (symbol);
>    unsigned char *data;
> -  int size;
> +  size_t size;
>  
>    data = find_location_expression (dlbaton, &size, ax->scope);
>    if (data == NULL)
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-05-18 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-18 10:26 Mark Kettenis
2003-05-18 15:11 ` Daniel Jacobowitz [this message]
2003-05-18 16:06   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030518151118.GA17081@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox