Re: [PATCH] Large array fix for Fortran.

[Daniel Jacobowitz <drow@mvista.com>]

On Fri, May 16, 2003 at 12:24:26PM +0100, David Lecomber wrote:
> Resubmitted as I now have copyright assignment..
> 
> This patch limits the number of elements printed from a
> multidimensional array to the correct number of elements, rather than
> the number of top level elements (eg. rows).  Very useful for most
> Fortran programmers, as they have a tendency to have obscenely large
> multi-d arrays and without this fix info locals, info args and others
> tend to be kinda slow..
> 
> A similar fix for C wouldn't go amiss, but is less urgent..
> 
> David

Some comments:

  - Missing ChangeLog.
  - You introduced a whitespace change on the before the body of
    f77_print_array_1; please try to avoid mixing whitespace changes
    with bug fixes.  Whitespace in your changes is a little bit off,
    too, for instance the two spaces before the &&:
> !       for (i = 0; i < F77_DIM_SIZE (nss)  && *elts < print_max; i++)
    and the space before the comma:
> !       for (i = 0; (i < F77_DIM_SIZE (nss) && (*elts) < print_max); i++ , (*elts)++)
    It may be trivial, but consistency in this sort of thing makes the
    code much easier to read.

Otherwise, this patch is OK.  I'd appreciate it if you could repost it
with ChangeLog and formatting fixes, though.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer