From: David Lecomber <david@streamline-computing.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Large array fix for Fortran.
Date: Fri, 16 May 2003 11:25:00 -0000 [thread overview]
Message-ID: <20030516122426.B31934@streamline-computing.com> (raw)
In-Reply-To: <20030115213240.A17967@streamline-computing.com>; from david@streamline-computing.com on Wed, Jan 15, 2003 at 09:32:40PM +0000
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
Resubmitted as I now have copyright assignment..
This patch limits the number of elements printed from a
multidimensional array to the correct number of elements, rather than
the number of top level elements (eg. rows). Very useful for most
Fortran programmers, as they have a tendency to have obscenely large
multi-d arrays and without this fix info locals, info args and others
tend to be kinda slow..
A similar fix for C wouldn't go amiss, but is less urgent..
David
[-- Attachment #2: gdb.huge-array-patch --]
[-- Type: text/plain, Size: 4228 bytes --]
*** f-valprint.c Wed Mar 7 02:57:08 2001
--- f-valprint.c Mon Oct 7 10:22:57 2002
*************** static void f77_print_array (struct type
*** 46,52 ****
enum val_prettyprint);
static void f77_print_array_1 (int, int, struct type *, char *,
CORE_ADDR, struct ui_file *, int, int, int,
! enum val_prettyprint);
static void f77_create_arrayprint_offset_tbl (struct type *,
struct ui_file *);
static void f77_get_dynamic_length_of_aggregate (struct type *);
--- 46,53 ----
enum val_prettyprint);
static void f77_print_array_1 (int, int, struct type *, char *,
CORE_ADDR, struct ui_file *, int, int, int,
! enum val_prettyprint,
! int *elts);
static void f77_create_arrayprint_offset_tbl (struct type *,
struct ui_file *);
static void f77_get_dynamic_length_of_aggregate (struct type *);
*************** f77_create_arrayprint_offset_tbl (struct
*** 270,300 ****
}
}
/* Actual function which prints out F77 arrays, Valaddr == address in
the superior. Address == the address in the inferior. */
-
static void
f77_print_array_1 (int nss, int ndimensions, struct type *type, char *valaddr,
CORE_ADDR address, struct ui_file *stream, int format,
! int deref_ref, int recurse, enum val_prettyprint pretty)
{
int i;
if (nss != ndimensions)
{
! for (i = 0; i < F77_DIM_SIZE (nss); i++)
{
fprintf_filtered (stream, "( ");
f77_print_array_1 (nss + 1, ndimensions, TYPE_TARGET_TYPE (type),
valaddr + i * F77_DIM_OFFSET (nss),
address + i * F77_DIM_OFFSET (nss),
! stream, format, deref_ref, recurse, pretty);
fprintf_filtered (stream, ") ");
}
}
else
{
! for (i = 0; (i < F77_DIM_SIZE (nss) && i < print_max); i++)
{
val_print (TYPE_TARGET_TYPE (type),
valaddr + i * F77_DIM_OFFSET (ndimensions),
--- 271,306 ----
}
}
+
+
/* Actual function which prints out F77 arrays, Valaddr == address in
the superior. Address == the address in the inferior. */
static void
f77_print_array_1 (int nss, int ndimensions, struct type *type, char *valaddr,
CORE_ADDR address, struct ui_file *stream, int format,
! int deref_ref, int recurse, enum val_prettyprint pretty,
! int *elts)
{
int i;
if (nss != ndimensions)
{
! for (i = 0; i < F77_DIM_SIZE (nss) && *elts < print_max; i++)
{
fprintf_filtered (stream, "( ");
f77_print_array_1 (nss + 1, ndimensions, TYPE_TARGET_TYPE (type),
valaddr + i * F77_DIM_OFFSET (nss),
address + i * F77_DIM_OFFSET (nss),
! stream, format, deref_ref, recurse, pretty, elts);
fprintf_filtered (stream, ") ");
}
+ if (*elts >= print_max && i < F77_DIM_SIZE (nss)) {
+ fprintf_filtered (stream, "...");
+ }
}
else
{
! for (i = 0; (i < F77_DIM_SIZE (nss) && (*elts) < print_max); i++ , (*elts)++)
{
val_print (TYPE_TARGET_TYPE (type),
valaddr + i * F77_DIM_OFFSET (ndimensions),
*************** f77_print_array_1 (int nss, int ndimensi
*** 305,311 ****
if (i != (F77_DIM_SIZE (nss) - 1))
fprintf_filtered (stream, ", ");
! if (i == print_max - 1)
fprintf_filtered (stream, "...");
}
}
--- 311,317 ----
if (i != (F77_DIM_SIZE (nss) - 1))
fprintf_filtered (stream, ", ");
! if (( *elts) > print_max - 1)
fprintf_filtered (stream, "...");
}
}
*************** f77_print_array (struct type *type, char
*** 320,325 ****
--- 326,332 ----
enum val_prettyprint pretty)
{
int ndimensions;
+ int elts = 0;
ndimensions = calc_f77_array_dims (type);
*************** f77_print_array (struct type *type, char
*** 334,340 ****
f77_create_arrayprint_offset_tbl (type, stream);
f77_print_array_1 (1, ndimensions, type, valaddr, address, stream, format,
! deref_ref, recurse, pretty);
}
\f
--- 341,347 ----
f77_create_arrayprint_offset_tbl (type, stream);
f77_print_array_1 (1, ndimensions, type, valaddr, address, stream, format,
! deref_ref, recurse, pretty, &elts);
}
\f
next prev parent reply other threads:[~2003-05-16 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 21:32 Patches to improve Fortran support David Lecomber
2003-05-16 11:24 ` [PATCH] Improvements to " David Lecomber
2003-05-16 15:25 ` Daniel Jacobowitz
2003-05-16 16:08 ` David Carlton
2003-05-16 11:25 ` David Lecomber [this message]
2003-05-16 15:32 ` [PATCH] Large array fix for Fortran Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030516122426.B31934@streamline-computing.com \
--to=david@streamline-computing.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox