From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9872 invoked by alias); 16 May 2003 15:32:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9865 invoked from network); 16 May 2003 15:32:49 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 16 May 2003 15:32:49 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19GhCv-0004nu-00; Fri, 16 May 2003 10:33:17 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19GhCQ-0001cI-00; Fri, 16 May 2003 11:32:46 -0400 Date: Fri, 16 May 2003 15:32:00 -0000 From: Daniel Jacobowitz To: David Lecomber Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Large array fix for Fortran. Message-ID: <20030516153246.GB5866@nevyn.them.org> Mail-Followup-To: David Lecomber , gdb-patches@sources.redhat.com References: <20030115213240.A17967@streamline-computing.com> <20030516122426.B31934@streamline-computing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030516122426.B31934@streamline-computing.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-05/txt/msg00280.txt.bz2 On Fri, May 16, 2003 at 12:24:26PM +0100, David Lecomber wrote: > Resubmitted as I now have copyright assignment.. > > This patch limits the number of elements printed from a > multidimensional array to the correct number of elements, rather than > the number of top level elements (eg. rows). Very useful for most > Fortran programmers, as they have a tendency to have obscenely large > multi-d arrays and without this fix info locals, info args and others > tend to be kinda slow.. > > A similar fix for C wouldn't go amiss, but is less urgent.. > > David Some comments: - Missing ChangeLog. - You introduced a whitespace change on the before the body of f77_print_array_1; please try to avoid mixing whitespace changes with bug fixes. Whitespace in your changes is a little bit off, too, for instance the two spaces before the &&: > ! for (i = 0; i < F77_DIM_SIZE (nss) && *elts < print_max; i++) and the space before the comma: > ! for (i = 0; (i < F77_DIM_SIZE (nss) && (*elts) < print_max); i++ , (*elts)++) It may be trivial, but consistency in this sort of thing makes the code much easier to read. Otherwise, this patch is OK. I'd appreciate it if you could repost it with ChangeLog and formatting fixes, though. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer