Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: mludvig@suse.cz
Cc: gdb-patches@sources.redhat.com, ac131313@redhat.com
Subject: Re: [offbyone RFC] Merge i386newframe
Date: Sun, 16 Mar 2003 12:48:00 -0000	[thread overview]
Message-ID: <200303161248.h2GCmHwN004525@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <3E71F890.7090304@suse.cz> (message from Michal Ludvig on Fri, 14 Mar 2003 16:43:12 +0100)

   Date: Fri, 14 Mar 2003 16:43:12 +0100
   From: Michal Ludvig <mludvig@suse.cz>

   Hi all,
   I've reworked the merge a little to avoid the need to reorder 
   frame.c:get_prev_frame() and fixed the 'next' and 'return' bugs that 
   were in the prevoius one. Now it passes the testsuite even better than 
   the i386newframe code did :-)
   I'm sorry I'm short of time to write more now.

   Andrew and Mark, please look around the patch and tell me your opinions.

Michal,

I appreciate your efforts here, but your patch introduces
Linux-specific code into i386-tdep.c.  I'm sorry, but we can't have
that.  I'll try to keep my i386newframe branch synced with HEAD.  I'm
afraid I don't have the time now to keep track of the offbyone branch
right now, but as Andrew merges things from there, I'll pick them up
in i386newframe.  I'll certainly take a look at your patch, and
incorporate the good bits.

Mark


  reply	other threads:[~2003-03-16 12:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-12 22:06 Michal Ludvig
2003-03-12 22:42 ` Daniel Jacobowitz
2003-03-13 19:05 ` Andrew Cagney
2003-03-13 22:46   ` Mark Kettenis
2003-03-14 15:48     ` Andrew Cagney
2003-03-14 16:19       ` Andrew Cagney
2003-03-14 18:20       ` Andrew Cagney
2003-04-06 17:10     ` Andrew Cagney
2003-04-07 18:53       ` Mark Kettenis
2003-03-14 11:54   ` Michal Ludvig
2003-03-14 15:59     ` Andrew Cagney
2003-03-14 15:43 ` Michal Ludvig
2003-03-16 12:48   ` Mark Kettenis [this message]
2003-03-17  7:52     ` Michal Ludvig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303161248.h2GCmHwN004525@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox