Re: [offbyone RFC] Merge i386newframe

[Michal Ludvig <mludvig@suse.cz>]

Mark Kettenis wrote:
>    Date: Fri, 14 Mar 2003 16:43:12 +0100
>    From: Michal Ludvig <mludvig@suse.cz>
> 
>    Hi all,
>    I've reworked the merge a little to avoid the need to reorder 
>    frame.c:get_prev_frame() and fixed the 'next' and 'return' bugs that 
>    were in the prevoius one. Now it passes the testsuite even better than 
>    the i386newframe code did :-)
>    I'm sorry I'm short of time to write more now.
> 
>    Andrew and Mark, please look around the patch and tell me your opinions.
> 
> Michal,
> 
> I appreciate your efforts here, but your patch introduces
> Linux-specific code into i386-tdep.c.  I'm sorry, but we can't have
> that.

Hmm, yes. Might be, because I don't use anything else but linux and 
don't have an idea what's different on non-linux targets. Is it only the 
i386_sigtramp_cache() that is different? Would it help if I moved 
sigtramp unwinders (or maybe only i386_sigtramp_cache()) into 
i386-linux-tdep.c?

Anyway could you or Andrew tell me if I did at least the linux bits 
right? I'd like to know if I could build x86-64 support in the same way 
or even better on top of i386?

>  I'll try to keep my i386newframe branch synced with HEAD.  I'm
> afraid I don't have the time now to keep track of the offbyone branch
> right now, but as Andrew merges things from there, I'll pick them up
> in i386newframe.  I'll certainly take a look at your patch, and
> incorporate the good bits.

The problem is that Andrew told me o use offbyone branch but I'd like to 
be in sync with you on i386newframe as well... But these two branches 
aren't compatible anymore.

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz