[commit] fix compilation error in hppa-tdep.c (hppa_pop_frame)

[commit] fix compilation error in hppa-tdep.c (hppa_pop_frame)

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

I just checked the following patch in to fix a small compilation error...

2002-12-13  Joel Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (hppa_pop_frame): Fix a compilation error introduced
        in the previous prototype change to set_momentary_breakpoint.

-- 
Joel

[-- Attachment #2: frame_id.diff --]
[-- Type: text/plain, Size: 944 bytes --]

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.39
diff -c -3 -p -r1.39 hppa-tdep.c
*** hppa-tdep.c	11 Dec 2002 20:35:43 -0000	1.39
--- hppa-tdep.c	13 Dec 2002 14:34:09 -0000
*************** hppa_pop_frame (void)
*** 1604,1610 ****
           for "return_command" will print the frame we returned to.  */
        sal = find_pc_line (target_pc, 0);
        sal.pc = target_pc;
!       breakpoint = set_momentary_breakpoint (sal, NULL, bp_finish);
        breakpoint->silent = 1;
  
        /* So we can clean things up.  */
--- 1604,1610 ----
           for "return_command" will print the frame we returned to.  */
        sal = find_pc_line (target_pc, 0);
        sal.pc = target_pc;
!       breakpoint = set_momentary_breakpoint (sal, null_frame_id, bp_finish);
        breakpoint->silent = 1;
  
        /* So we can clean things up.  */

Re: [commit] fix compilation error in hppa-tdep.c (hppa_pop_frame)

[Andrew Cagney]

> I just checked the following patch in to fix a small compilation error...
> 
> 2002-12-13  Joel Brobecker  <brobecker@gnat.com>
> 
>         * hppa-tdep.c (hppa_pop_frame): Fix a compilation error introduced
>         in the previous prototype change to set_momentary_breakpoint.
> 

Oops, thanks!  What are the odds of getting --target=hppa-elf (a minimal 
hppa target) building?  That should stop me breaking the HPPA in this way.

Andrew

Re: [commit] fix compilation error in hppa-tdep.c (hppa_pop_frame)

[Joel Brobecker]

> Oops, thanks!  What are the odds of getting --target=hppa-elf (a minimal 
> hppa target) building?  That should stop me breaking the HPPA in this way.

The odds at the moment are very small, at least because of the following
includes in hppa-tdep.c (I think):

        #ifdef USG
        #include <sys/types.h>
        #endif
        
        #include <dl.h>
        #include <sys/param.h>
        #include <signal.h>
        
        #include <sys/ptrace.h>
        #include <machine/save_state.h>

(etc)

I plan on working on these after having done the minimal work to be done
with the conversion. In the meantime, I won't complain about anybody
breaking hppa by mistake (I would not complain anyway, actually).

-- 
Joel