From: DJ Delorie <dj@redhat.com>
To: neroden@twcny.rr.com
Cc: gcc-patches@gcc.gnu.org, binutils@sources.redhat.com,
gdb-patches@sources.redhat.com
Subject: Re: Toplevel patch: Autogenerate Makefile targets 2 (*-target-*)
Date: Wed, 13 Nov 2002 13:53:00 -0000 [thread overview]
Message-ID: <200211132153.gADLrew14262@greed.delorie.com> (raw)
In-Reply-To: <20021113195200.GA28331@doctormoo> (message from Nathanael Nerode on Wed, 13 Nov 2002 14:52:00 -0500)
> * Makefile.tpl: Autogenerate *-target-* targets.
> * Makefile.in: Regenerate.
> - @dir=`echo $@ | sed -e 's/configure-target-//'`; \
> + dir=[+module+] ; \
You dropped the '@' here. The '@' is a make thing, not part of the
scriptlet.
> -$(ALL_TARGET_MODULES):
> - @dir=`echo $@ | sed -e 's/all-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +.PHONY: all-target-[+module+]
> +all-target-[+module+]:
> + dir=[+module+] ; \
'@' here.
> -$(CHECK_TARGET_MODULES):
> - @dir=`echo $@ | sed -e 's/check-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ IF no_check +][+ ELSE check +]
Is this the best place for this IF?
> +.PHONY: check-target-[+module+]
> +check-target-[+module+]:
> + dir=[+module+] ; \
'@' here.
> -$(INSTALL_TARGET_MODULES): installdirs
> - @dir=`echo $@ | sed -e 's/install-target-//'`; \
> - if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ ENDIF no_check +]
This endif looks out of place.
> +[+ IF no_install +][+ ELSE install +]\
> +.PHONY: install-target-[+module+]
> +install-target-[+module+]: installdirs
> + dir=[+module+] ; \
'@' here.
prev parent reply other threads:[~2002-11-13 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 11:52 Nathanael Nerode
2002-11-13 13:53 ` DJ Delorie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211132153.gADLrew14262@greed.delorie.com \
--to=dj@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=neroden@twcny.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox