From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20141-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 5361 invoked by alias); 13 Nov 2002 21:53:43 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5341 invoked from network); 13 Nov 2002 21:53:42 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 13 Nov 2002 21:53:42 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gADLUSw07635;
	Wed, 13 Nov 2002 16:30:28 -0500
Received: from post-office.corp.redhat.com (post-office.corp.redhat.com [172.16.52.227])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gADLrfD11408;
	Wed, 13 Nov 2002 16:53:41 -0500
Received: from greed.delorie.com (dj.cipe.redhat.com [10.0.0.222])
	by post-office.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gADLrfl20811;
	Wed, 13 Nov 2002 16:53:41 -0500
Received: (from dj@localhost)
	by greed.delorie.com (8.11.6/8.11.6) id gADLrew14262;
	Wed, 13 Nov 2002 16:53:40 -0500
Date: Wed, 13 Nov 2002 13:53:00 -0000
Message-Id: <200211132153.gADLrew14262@greed.delorie.com>
From: DJ Delorie <dj@redhat.com>
To: neroden@twcny.rr.com
CC: gcc-patches@gcc.gnu.org, binutils@sources.redhat.com,
   gdb-patches@sources.redhat.com
In-reply-to: <20021113195200.GA28331@doctormoo> (message from Nathanael Nerode
	on Wed, 13 Nov 2002 14:52:00 -0500)
Subject: Re: Toplevel patch: Autogenerate Makefile targets 2 (*-target-*)
References:  <20021113195200.GA28331@doctormoo>
X-SW-Source: 2002-11/txt/msg00397.txt.bz2


> 	* Makefile.tpl: Autogenerate *-target-* targets.
> 	* Makefile.in: Regenerate.

> -	@dir=`echo $@ | sed -e 's/configure-target-//'`; \
> +	dir=[+module+] ; \

You dropped the '@' here.  The '@' is a make thing, not part of the
scriptlet.

> -$(ALL_TARGET_MODULES):
> -	@dir=`echo $@ | sed -e 's/all-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +.PHONY: all-target-[+module+]
> +all-target-[+module+]:
> +	dir=[+module+] ; \

'@' here.

> -$(CHECK_TARGET_MODULES):
> -	@dir=`echo $@ | sed -e 's/check-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ IF no_check +][+ ELSE check +]

Is this the best place for this IF?

> +.PHONY: check-target-[+module+]
> +check-target-[+module+]:
> +	dir=[+module+] ; \

'@' here.

> -$(INSTALL_TARGET_MODULES): installdirs
> -	@dir=`echo $@ | sed -e 's/install-target-//'`; \
> -	if [ -f $(TARGET_SUBDIR)/$${dir}/Makefile ] ; then \
> +[+ ENDIF no_check +]

This endif looks out of place.

> +[+ IF no_install +][+ ELSE install +]\
> +.PHONY: install-target-[+module+]
> +install-target-[+module+]: installdirs
> +	dir=[+module+] ; \

'@' here.