[RFA] testsuite/gdb.base/commands.exp: Don't expect "Program exited normally" string

[RFA] testsuite/gdb.base/commands.exp: Don't expect "Program exited normally" string

[Corinna Vinschen]

Hi,

the command.exp test expects the string "Program exited normally" when
testing commands execution on breakpoints.  This might fail on some
remote targets and simulators which never reaches a normal exit but
stop execution at some defined trap in _exit() or friend.

For that reason I'd propose to drop the above expectation from the test.

Corinna

	* gdb.base/commands.exp: Don't expect a "Program exited normally"
	string after running the commands execution on breakpoint tests.

Index: gdb.base/commands.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
retrieving revision 1.11
diff -u -p -r1.11 commands.exp
--- gdb.base/commands.exp	27 Aug 2002 01:09:09 -0000	1.11
+++ gdb.base/commands.exp	13 Sep 2002 14:45:28 -0000
@@ -490,7 +490,7 @@ proc bp_deleted_in_command_test {} {
 
     gdb_run_cmd
     gdb_expect {
-        -re ".*factorial command-list executed.*1.*Program exited normally.*$gdb_prompt $" {
+        -re ".*factorial command-list executed.*1.*$gdb_prompt $" {
 	    pass "run factorial until breakpoint"
         }
 	-re ".*$gdb_prompt $" {
@@ -547,7 +547,7 @@ proc temporary_breakpoint_commands {} {
 
     gdb_run_cmd
     gdb_expect {
-	-re ".*factorial tbreak commands executed.*1.*Program exited normally.*" {
+	-re ".*factorial tbreak commands executed.*1.*$gdb_prompt $" {
 	    pass "run factorial until temporary breakpoint"
 	}
 	timeout { fail "(timeout) run factorial until temporary breakpoint" }

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [RFA] testsuite/gdb.base/commands.exp: Don't expect "Program exited normally" string

[Fernando Nasser]

Approved.  The important here is to see if the commands were executed, 
the Program exited normally (or similar message) is not important
(as long as we get the prompt back, of course).

Thanks for the fix.

Fernando

Corinna Vinschen wrote:
> Hi,
> 
> the command.exp test expects the string "Program exited normally" when
> testing commands execution on breakpoints.  This might fail on some
> remote targets and simulators which never reaches a normal exit but
> stop execution at some defined trap in _exit() or friend.
> 
> For that reason I'd propose to drop the above expectation from the test.
> 
> Corinna
> 
> 	* gdb.base/commands.exp: Don't expect a "Program exited normally"
> 	string after running the commands execution on breakpoint tests.
> 
> Index: gdb.base/commands.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
> retrieving revision 1.11
> diff -u -p -r1.11 commands.exp
> --- gdb.base/commands.exp	27 Aug 2002 01:09:09 -0000	1.11
> +++ gdb.base/commands.exp	13 Sep 2002 14:45:28 -0000
> @@ -490,7 +490,7 @@ proc bp_deleted_in_command_test {} {
>  
>      gdb_run_cmd
>      gdb_expect {
> -        -re ".*factorial command-list executed.*1.*Program exited normally.*$gdb_prompt $" {
> +        -re ".*factorial command-list executed.*1.*$gdb_prompt $" {
>  	    pass "run factorial until breakpoint"
>          }
>  	-re ".*$gdb_prompt $" {
> @@ -547,7 +547,7 @@ proc temporary_breakpoint_commands {} {
>  
>      gdb_run_cmd
>      gdb_expect {
> -	-re ".*factorial tbreak commands executed.*1.*Program exited normally.*" {
> +	-re ".*factorial tbreak commands executed.*1.*$gdb_prompt $" {
>  	    pass "run factorial until temporary breakpoint"
>  	}
>  	timeout { fail "(timeout) run factorial until temporary breakpoint" }
> 


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: [RFA] testsuite/gdb.base/commands.exp: Don't expect "Program exited normally" string

[Corinna Vinschen]

On Fri, Sep 13, 2002 at 03:10:15PM -0400, Fernando Nasser wrote:
> Approved.  The important here is to see if the commands were executed, 

Thanks, applied.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com