From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6843 invoked by alias); 13 Sep 2002 19:11:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6836 invoked from network); 13 Sep 2002 19:11:28 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 13 Sep 2002 19:11:28 -0000 Received: from redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id BA0E2B8831 for ; Fri, 13 Sep 2002 15:11:27 -0400 (EDT) Message-ID: <3D823817.50506@redhat.com> Date: Fri, 13 Sep 2002 12:11:00 -0000 From: Fernando Nasser Organization: Red Hat Canada User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.base/commands.exp: Don't expect "Program exited normally" string References: <20020913164944.F1574@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-09/txt/msg00259.txt.bz2 Approved. The important here is to see if the commands were executed, the Program exited normally (or similar message) is not important (as long as we get the prompt back, of course). Thanks for the fix. Fernando Corinna Vinschen wrote: > Hi, > > the command.exp test expects the string "Program exited normally" when > testing commands execution on breakpoints. This might fail on some > remote targets and simulators which never reaches a normal exit but > stop execution at some defined trap in _exit() or friend. > > For that reason I'd propose to drop the above expectation from the test. > > Corinna > > * gdb.base/commands.exp: Don't expect a "Program exited normally" > string after running the commands execution on breakpoint tests. > > Index: gdb.base/commands.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v > retrieving revision 1.11 > diff -u -p -r1.11 commands.exp > --- gdb.base/commands.exp 27 Aug 2002 01:09:09 -0000 1.11 > +++ gdb.base/commands.exp 13 Sep 2002 14:45:28 -0000 > @@ -490,7 +490,7 @@ proc bp_deleted_in_command_test {} { > > gdb_run_cmd > gdb_expect { > - -re ".*factorial command-list executed.*1.*Program exited normally.*$gdb_prompt $" { > + -re ".*factorial command-list executed.*1.*$gdb_prompt $" { > pass "run factorial until breakpoint" > } > -re ".*$gdb_prompt $" { > @@ -547,7 +547,7 @@ proc temporary_breakpoint_commands {} { > > gdb_run_cmd > gdb_expect { > - -re ".*factorial tbreak commands executed.*1.*Program exited normally.*" { > + -re ".*factorial tbreak commands executed.*1.*$gdb_prompt $" { > pass "run factorial until temporary breakpoint" > } > timeout { fail "(timeout) run factorial until temporary breakpoint" } > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9