From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix bug gdb/321
Date: Thu, 11 Jul 2002 12:33:00 -0000 [thread overview]
Message-ID: <20020711213010.W21857@cygbert.vinschen.de> (raw)
In-Reply-To: <20020711185603.GA22051@nevyn.them.org>
On Thu, Jul 11, 2002 at 02:56:03PM -0400, Daniel Jacobowitz wrote:
> On Thu, Jul 11, 2002 at 08:52:08PM +0200, Corinna Vinschen wrote:
> > Hi,
> >
> > the following patch seems to fix the bug described in gdb/321:
> >
> > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=321
> >
> > Basically the problem is that gdb's backtrace reports the wrong calling
> > function if a function ends in a call to abort() (or another noreturn func)
> > under some conditions. The bug report suggests to use a by one decremented
> > pc when evaluating the function. The following patch does exactly this by
> > using the return value of frame_address_in_block() instead of frame->pc in
> > calls which evaluate symbols.
>
> FWIW, I think this is perfect - thanks!
Applied.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com
next prev parent reply other threads:[~2002-07-11 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-11 11:55 Corinna Vinschen
2002-07-11 12:02 ` Daniel Jacobowitz
2002-07-11 12:33 ` Corinna Vinschen [this message]
2002-07-11 12:35 ` Daniel Jacobowitz
2002-07-11 12:40 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020711213010.W21857@cygbert.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox