From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28337 invoked by alias); 11 Jul 2002 19:30:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28330 invoked from network); 11 Jul 2002 19:30:15 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 11 Jul 2002 19:30:15 -0000 Received: from cygbert.vinschen.de (vpn3-4.sfbay.redhat.com [172.16.25.4]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6BJV2Q29039 for ; Thu, 11 Jul 2002 12:31:02 -0700 Received: (from corinna@localhost) by cygbert.vinschen.de (8.11.6/8.9.3/Linux sendmail 8.9.3) id g6BJUAe10796 for gdb-patches@sources.redhat.com; Thu, 11 Jul 2002 21:30:10 +0200 Date: Thu, 11 Jul 2002 12:33:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix bug gdb/321 Message-ID: <20020711213010.W21857@cygbert.vinschen.de> Reply-To: gdb-patches Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020711205208.U21857@cygbert.vinschen.de> <20020711185603.GA22051@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020711185603.GA22051@nevyn.them.org> User-Agent: Mutt/1.3.22.1i X-SW-Source: 2002-07/txt/msg00244.txt.bz2 On Thu, Jul 11, 2002 at 02:56:03PM -0400, Daniel Jacobowitz wrote: > On Thu, Jul 11, 2002 at 08:52:08PM +0200, Corinna Vinschen wrote: > > Hi, > > > > the following patch seems to fix the bug described in gdb/321: > > > > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=321 > > > > Basically the problem is that gdb's backtrace reports the wrong calling > > function if a function ends in a call to abort() (or another noreturn func) > > under some conditions. The bug report suggests to use a by one decremented > > pc when evaluating the function. The following patch does exactly this by > > using the return value of frame_address_in_block() instead of frame->pc in > > calls which evaluate symbols. > > FWIW, I think this is perfect - thanks! Applied. Thanks, Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com