Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix bug gdb/321
Date: Thu, 11 Jul 2002 12:35:00 -0000	[thread overview]
Message-ID: <20020711193308.GA9721@nevyn.them.org> (raw)
In-Reply-To: <20020711213010.W21857@cygbert.vinschen.de>

On Thu, Jul 11, 2002 at 09:30:10PM +0200, Corinna Vinschen wrote:
> On Thu, Jul 11, 2002 at 02:56:03PM -0400, Daniel Jacobowitz wrote:
> > On Thu, Jul 11, 2002 at 08:52:08PM +0200, Corinna Vinschen wrote:
> > > Hi,
> > > 
> > > the following patch seems to fix the bug described in gdb/321:
> > > 
> > > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=321
> > > 
> > > Basically the problem is that gdb's backtrace reports the wrong calling
> > > function if a function ends in a call to abort() (or another noreturn func)
> > > under some conditions.  The bug report suggests to use a by one decremented
> > > pc when evaluating the function.  The following patch does exactly this by
> > > using the return value of frame_address_in_block() instead of frame->pc in
> > > calls which evaluate symbols.
> > 
> > FWIW, I think this is perfect - thanks!
> 
> Applied.

For the record, I can't approve patches - although this one was fairly
obvious, so I don't think anyone will complain.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-07-11 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-11 11:55 Corinna Vinschen
2002-07-11 12:02 ` Daniel Jacobowitz
2002-07-11 12:33   ` Corinna Vinschen
2002-07-11 12:35     ` Daniel Jacobowitz [this message]
2002-07-11 12:40       ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020711193308.GA9721@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox