From: Daniel Jacobowitz <drow@mvista.com>
To: David O'Brien <obrien@FreeBSD.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] gdbreplay.c
Date: Tue, 09 Jul 2002 10:36:00 -0000 [thread overview]
Message-ID: <20020709173322.GA28223@nevyn.them.org> (raw)
In-Reply-To: <20020709172541.GA26506@dragon.nuxi.com>
On Tue, Jul 09, 2002 at 10:25:41AM -0700, David O'Brien wrote:
> I'd like to commit this change.
>
> This seems more proper for the includes includes, and the staticization
> is needed to quiet GCC at high warning levels.
I'm not sure if you're asking or telling since it sounds like you've
committed the matching patch to the 5.2 branch?
In any case, no objection, so please commit it. But when does GCC warn
about a function not being static? Doesn't make a lot of sense to me;
it doesn't know that you won't link with -Bsymbolic and use DSO's, for
instance.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-07-09 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-09 10:33 David O'Brien
2002-07-09 10:36 ` Daniel Jacobowitz [this message]
2002-07-09 12:49 ` David O'Brien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020709173322.GA28223@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=obrien@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox