From: "David O'Brien" <obrien@FreeBSD.org>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] gdbreplay.c
Date: Tue, 09 Jul 2002 10:33:00 -0000 [thread overview]
Message-ID: <20020709172541.GA26506@dragon.nuxi.com> (raw)
I'd like to commit this change.
This seems more proper for the includes includes, and the staticization
is needed to quiet GCC at high warning levels.
Index: gdbreplay.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/gdbreplay.c,v
retrieving revision 1.6
diff -u -r1.6 gdbreplay.c
--- gdbreplay.c 9 Apr 2002 21:11:35 -0000 1.6
+++ gdbreplay.c 9 Jul 2002 17:23:26 -0000
@@ -30,12 +30,16 @@
#include <ctype.h>
#include <fcntl.h>
#include <errno.h>
-#include <stdlib.h>
-#include <unistd.h>
+#ifdef HAVE_STDLIB_H
+#include <stdlib.h>
+#endif
#ifdef HAVE_STRING_H
#include <string.h>
#endif
+#ifdef HAVE_UNISTD_H
+#include <unistd.h>
+#endif
/* Sort of a hack... */
#define EOL (EOF - 1)
@@ -46,7 +50,7 @@
as the file name for which the error was encountered.
Then return to command level. */
-void
+static void
perror_with_name (char *string)
{
#ifndef STDC_HEADERS
@@ -77,7 +81,7 @@
exit (1);
}
-void
+static void
remote_close (void)
{
close (remote_desc);
@@ -86,7 +90,7 @@
/* Open a connection to a remote debugger.
NAME is the filename used for communication. */
-void
+static void
remote_open (char *name)
{
if (!strchr (name, ':'))
@@ -234,7 +238,7 @@
/* Accept input from gdb and match with chars from fp (after skipping one
blank) up until a \n is read from fp (which is not matched) */
-void
+static void
expect (FILE *fp)
{
int fromlog;
@@ -265,7 +269,7 @@
/* Play data back to gdb from fp (after skipping leading blank) up until a
\n is read from fp (which is discarded and not sent to gdb). */
-void
+static void
play (FILE *fp)
{
int fromlog;
next reply other threads:[~2002-07-09 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-09 10:33 David O'Brien [this message]
2002-07-09 10:36 ` Daniel Jacobowitz
2002-07-09 12:49 ` David O'Brien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020709172541.GA26506@dragon.nuxi.com \
--to=obrien@freebsd.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox