From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31143 invoked by alias); 9 Jul 2002 17:33:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31129 invoked from network); 9 Jul 2002 17:33:28 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 9 Jul 2002 17:33:28 -0000 Received: from dsl254-114-096.nyc1.dsl.speakeasy.net ([216.254.114.96] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17Ryrb-0002PT-00; Tue, 09 Jul 2002 12:33:23 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17Ryra-0000v1-00; Tue, 09 Jul 2002 13:33:22 -0400 Date: Tue, 09 Jul 2002 10:36:00 -0000 From: Daniel Jacobowitz To: David O'Brien Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] gdbreplay.c Message-ID: <20020709173322.GA28223@nevyn.them.org> Mail-Followup-To: David O'Brien , gdb-patches@sources.redhat.com References: <20020709172541.GA26506@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020709172541.GA26506@dragon.nuxi.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-07/txt/msg00156.txt.bz2 On Tue, Jul 09, 2002 at 10:25:41AM -0700, David O'Brien wrote: > I'd like to commit this change. > > This seems more proper for the includes includes, and the staticization > is needed to quiet GCC at high warning levels. I'm not sure if you're asking or telling since it sounds like you've committed the matching patch to the 5.2 branch? In any case, no objection, so please commit it. But when does GCC warn about a function not being static? Doesn't make a lot of sense to me; it doesn't know that you won't link with -Bsymbolic and use DSO's, for instance. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer