Re: RFA/testsuite: test break "marker2"

Re: RFA/testsuite: test break "marker2"

[Michael Elizabeth Chastain]

This patch is approved, as long as you update the copyright year
in gdb.base/break.exp.

Thanks for the test,

Michael C

2002-05-10  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.base/break.exp: Check 'break "marker2"'.

Re: RFA/testsuite: test break "marker2"

[Daniel Jacobowitz]

On Sun, May 12, 2002 at 11:43:00AM -0500, Michael Elizabeth Chastain wrote:
> This patch is approved, as long as you update the copyright year
> in gdb.base/break.exp.
> 
> Thanks for the test,
> 
> Michael C
> 
> 2002-05-10  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* gdb.base/break.exp: Check 'break "marker2"'.

Thanks, committed.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: RFA/testsuite: test break "marker2"

[Elena Zannoni]

Daniel Jacobowitz writes:
 > Elena pointed out that this doesn't seem to be in the testsuite anywhere. 
 > I'm considering writing unit tests for some of the linespec code... but
 > until then, I'll just keep adding breakpoint tests.  Is this OK?  Should
 > pass everywhere.
 > 

Can you add a comment about testing decode_line_1 code?

My turn to recommend this for approval to MichaelC. :-)

Thanks
Elena


 > -- 
 > Daniel Jacobowitz                           Carnegie Mellon University
 > MontaVista Software                         Debian GNU/Linux Developer
 > 
 > 2002-05-10  Daniel Jacobowitz  <drow@mvista.com>
 > 
 > 	* gdb.base/break.exp: Check 'break "marker2"'.
 > 
 > Index: testsuite/gdb.base/break.exp
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
 > retrieving revision 1.11
 > diff -u -p -r1.11 break.exp
 > --- testsuite/gdb.base/break.exp	7 Jan 2002 19:21:27 -0000	1.11
 > +++ testsuite/gdb.base/break.exp	10 May 2002 19:38:45 -0000
 > @@ -84,6 +84,13 @@ gdb_test "break main" \
 >      "breakpoint function"
 >  
 >  #
 > +# test break at quoted function
 > +#
 > +gdb_test "break \"marker2\"" \
 > +    "Breakpoint.*at.* file .*$srcfile, line.*" \
 > +    "breakpoint quoted function"
 > +
 > +#
 >  # test break at function in file
 >  #
 >  gdb_test "break $srcfile:factorial" \
 > @@ -150,6 +157,7 @@ if {$hp_aCC_compiler} {
 >  gdb_test "info break" \
 >      "Num Type\[ \]+Disp Enb Address\[ \]+What.*
 >  \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$main_line.*
 > +\[0-9\]+\[\t \]+breakpoint     keep y.* in marker2 at .*$srcfile:4\[49\].*
 >  \[0-9\]+\[\t \]+breakpoint     keep y.* in factorial$proto at .*$srcfile:96.*
 >  \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:79.*
 >  \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:79.*
 > @@ -208,6 +216,11 @@ for {set i 6} {$i >= 1} {incr i -1} {
 >  			"run until file:function($i) breakpoint"
 >  }
 >  
 > +#
 > +# Run until the breakpoint set at a quoted function
 > +#
 > +gdb_test continue "Continuing\\..*Breakpoint \[0-9\]+, (0x\[0-9a-f\]+ in )?marker2 \\(a=43\\) at .*$srcfile:4\[49\].*" \
 > +		"run until quoted breakpoint"
 >  #
 >  # run until the file:function breakpoint at a line number in a file
 >  #

RFA/testsuite: test break "marker2"

[Daniel Jacobowitz]

Elena pointed out that this doesn't seem to be in the testsuite anywhere. 
I'm considering writing unit tests for some of the linespec code... but
until then, I'll just keep adding breakpoint tests.  Is this OK?  Should
pass everywhere.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

2002-05-10  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.base/break.exp: Check 'break "marker2"'.

Index: testsuite/gdb.base/break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
retrieving revision 1.11
diff -u -p -r1.11 break.exp
--- testsuite/gdb.base/break.exp	7 Jan 2002 19:21:27 -0000	1.11
+++ testsuite/gdb.base/break.exp	10 May 2002 19:38:45 -0000
@@ -84,6 +84,13 @@ gdb_test "break main" \
     "breakpoint function"
 
 #
+# test break at quoted function
+#
+gdb_test "break \"marker2\"" \
+    "Breakpoint.*at.* file .*$srcfile, line.*" \
+    "breakpoint quoted function"
+
+#
 # test break at function in file
 #
 gdb_test "break $srcfile:factorial" \
@@ -150,6 +157,7 @@ if {$hp_aCC_compiler} {
 gdb_test "info break" \
     "Num Type\[ \]+Disp Enb Address\[ \]+What.*
 \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$main_line.*
+\[0-9\]+\[\t \]+breakpoint     keep y.* in marker2 at .*$srcfile:4\[49\].*
 \[0-9\]+\[\t \]+breakpoint     keep y.* in factorial$proto at .*$srcfile:96.*
 \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:79.*
 \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:79.*
@@ -208,6 +216,11 @@ for {set i 6} {$i >= 1} {incr i -1} {
 			"run until file:function($i) breakpoint"
 }
 
+#
+# Run until the breakpoint set at a quoted function
+#
+gdb_test continue "Continuing\\..*Breakpoint \[0-9\]+, (0x\[0-9a-f\]+ in )?marker2 \\(a=43\\) at .*$srcfile:4\[49\].*" \
+		"run until quoted breakpoint"
 #
 # run until the file:function breakpoint at a line number in a file
 #