From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22480 invoked by alias); 10 May 2002 19:59:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22458 invoked from network); 10 May 2002 19:59:25 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 10 May 2002 19:59:25 -0000 Received: from localhost.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA04199 for ; Fri, 10 May 2002 12:59:23 -0700 (PDT) Received: by localhost.redhat.com (Postfix, from userid 469) id 261D710AAC; Fri, 10 May 2002 15:58:46 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15580.9846.576737.468732@localhost.redhat.com> Date: Fri, 10 May 2002 12:59:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFA/testsuite: test break "marker2" In-Reply-To: <20020510194918.GA3893@nevyn.them.org> References: <20020510194918.GA3893@nevyn.them.org> X-SW-Source: 2002-05/txt/msg00362.txt.bz2 Daniel Jacobowitz writes: > Elena pointed out that this doesn't seem to be in the testsuite anywhere. > I'm considering writing unit tests for some of the linespec code... but > until then, I'll just keep adding breakpoint tests. Is this OK? Should > pass everywhere. > Can you add a comment about testing decode_line_1 code? My turn to recommend this for approval to MichaelC. :-) Thanks Elena > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer > > 2002-05-10 Daniel Jacobowitz > > * gdb.base/break.exp: Check 'break "marker2"'. > > Index: testsuite/gdb.base/break.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v > retrieving revision 1.11 > diff -u -p -r1.11 break.exp > --- testsuite/gdb.base/break.exp 7 Jan 2002 19:21:27 -0000 1.11 > +++ testsuite/gdb.base/break.exp 10 May 2002 19:38:45 -0000 > @@ -84,6 +84,13 @@ gdb_test "break main" \ > "breakpoint function" > > # > +# test break at quoted function > +# > +gdb_test "break \"marker2\"" \ > + "Breakpoint.*at.* file .*$srcfile, line.*" \ > + "breakpoint quoted function" > + > +# > # test break at function in file > # > gdb_test "break $srcfile:factorial" \ > @@ -150,6 +157,7 @@ if {$hp_aCC_compiler} { > gdb_test "info break" \ > "Num Type\[ \]+Disp Enb Address\[ \]+What.* > \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$main_line.* > +\[0-9\]+\[\t \]+breakpoint keep y.* in marker2 at .*$srcfile:4\[49\].* > \[0-9\]+\[\t \]+breakpoint keep y.* in factorial$proto at .*$srcfile:96.* > \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:79.* > \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:79.* > @@ -208,6 +216,11 @@ for {set i 6} {$i >= 1} {incr i -1} { > "run until file:function($i) breakpoint" > } > > +# > +# Run until the breakpoint set at a quoted function > +# > +gdb_test continue "Continuing\\..*Breakpoint \[0-9\]+, (0x\[0-9a-f\]+ in )?marker2 \\(a=43\\) at .*$srcfile:4\[49\].*" \ > + "run until quoted breakpoint" > # > # run until the file:function breakpoint at a line number in a file > #