* [RFA] valops.c: don't coerce vectors.
@ 2002-04-29 14:47 Elena Zannoni
2002-05-02 12:04 ` Elena Zannoni
0 siblings, 1 reply; 10+ messages in thread
From: Elena Zannoni @ 2002-04-29 14:47 UTC (permalink / raw)
To: gdb-patches
I hope this is the last of the AltiVec series.
Elena
2002-04-29 Elena Zannoni <ezannoni@redhat.com>
* valops.c (value_arg_coerce): Don't coerce arrays to pointers if
we are dealing with vectors.
Index: valops.c
===================================================================
RCS file: /cvs/uberbaum/gdb/valops.c,v
retrieving revision 1.55
diff -u -p -r1.55 valops.c
--- valops.c 26 Apr 2002 03:37:42 -0000 1.55
+++ valops.c 29 Apr 2002 21:45:55 -0000
@@ -1190,8 +1190,12 @@ value_arg_coerce (struct value *arg, str
type = lookup_pointer_type (type);
break;
case TYPE_CODE_ARRAY:
+ /* Arrays are coerced to pointers to their first element, unless
+ they are vectors, in which case we want to leave them alone,
+ because they are passed by value. */
if (current_language->c_style_arrays)
- type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
+ if (!TYPE_VECTOR (type))
+ type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
break;
case TYPE_CODE_UNDEF:
case TYPE_CODE_PTR:
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [RFA] valops.c: don't coerce vectors.
2002-04-29 14:47 [RFA] valops.c: don't coerce vectors Elena Zannoni
@ 2002-05-02 12:04 ` Elena Zannoni
2002-05-02 12:08 ` Daniel Jacobowitz
0 siblings, 1 reply; 10+ messages in thread
From: Elena Zannoni @ 2002-05-02 12:04 UTC (permalink / raw)
To: Elena Zannoni; +Cc: gdb-patches
Elena Zannoni writes:
>
> I hope this is the last of the AltiVec series.
>
> Elena
>
> 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
>
> * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> we are dealing with vectors.
>
>
I committed this, given that the file seems unmaintained.
Elena
> Index: valops.c
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/valops.c,v
> retrieving revision 1.55
> diff -u -p -r1.55 valops.c
> --- valops.c 26 Apr 2002 03:37:42 -0000 1.55
> +++ valops.c 29 Apr 2002 21:45:55 -0000
> @@ -1190,8 +1190,12 @@ value_arg_coerce (struct value *arg, str
> type = lookup_pointer_type (type);
> break;
> case TYPE_CODE_ARRAY:
> + /* Arrays are coerced to pointers to their first element, unless
> + they are vectors, in which case we want to leave them alone,
> + because they are passed by value. */
> if (current_language->c_style_arrays)
> - type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
> + if (!TYPE_VECTOR (type))
> + type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
> break;
> case TYPE_CODE_UNDEF:
> case TYPE_CODE_PTR:
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 12:04 ` Elena Zannoni
@ 2002-05-02 12:08 ` Daniel Jacobowitz
2002-05-02 12:19 ` Elena Zannoni
2002-05-02 14:21 ` Michael Snyder
0 siblings, 2 replies; 10+ messages in thread
From: Daniel Jacobowitz @ 2002-05-02 12:08 UTC (permalink / raw)
To: gdb-patches
On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> Elena Zannoni writes:
> >
> > I hope this is the last of the AltiVec series.
> >
> > Elena
> >
> > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> >
> > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > we are dealing with vectors.
> >
> >
>
> I committed this, given that the file seems unmaintained.
FYI, I was told that the value support files are all considered
"language support" and require explicit approval from a blanket write
maintainer.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 12:08 ` Daniel Jacobowitz
@ 2002-05-02 12:19 ` Elena Zannoni
2002-05-02 14:45 ` Michael Snyder
2002-05-02 14:21 ` Michael Snyder
1 sibling, 1 reply; 10+ messages in thread
From: Elena Zannoni @ 2002-05-02 12:19 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
Daniel Jacobowitz writes:
> On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > Elena Zannoni writes:
> > >
> > > I hope this is the last of the AltiVec series.
> > >
> > > Elena
> > >
> > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > >
> > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > we are dealing with vectors.
> > >
> > >
> >
> > I committed this, given that the file seems unmaintained.
>
> FYI, I was told that the value support files are all considered
> "language support" and require explicit approval from a blanket write
> maintainer.
>
I am such a maintainer.
Elena
> --
> Daniel Jacobowitz Carnegie Mellon University
> MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 12:19 ` Elena Zannoni
@ 2002-05-02 14:45 ` Michael Snyder
2002-05-02 17:36 ` Elena Zannoni
0 siblings, 1 reply; 10+ messages in thread
From: Michael Snyder @ 2002-05-02 14:45 UTC (permalink / raw)
To: Elena Zannoni; +Cc: Daniel Jacobowitz, gdb-patches
Elena Zannoni wrote:
>
> Daniel Jacobowitz writes:
> > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > > Elena Zannoni writes:
> > > >
> > > > I hope this is the last of the AltiVec series.
> > > >
> > > > Elena
> > > >
> > > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > > >
> > > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > > we are dealing with vectors.
> > > >
> > > >
> > >
> > > I committed this, given that the file seems unmaintained.
> >
> > FYI, I was told that the value support files are all considered
> > "language support" and require explicit approval from a blanket write
> > maintainer.
> >
>
> I am such a maintainer.
Oops -- this was supposed to be a reply to Elena's post. >;-)
In place of a Dark Lord you would have a QUEEN!!
And I shall not be dark but beautiful and terrible to behold!!
Fair as the Sea and the Sun and the Snow upon the Mountain!!
Dreaful as the Storm and Lightning!! Stronger than the
foundations of the earth!! All shall love me and despair!!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 14:45 ` Michael Snyder
@ 2002-05-02 17:36 ` Elena Zannoni
2002-05-02 17:51 ` Michael Snyder
0 siblings, 1 reply; 10+ messages in thread
From: Elena Zannoni @ 2002-05-02 17:36 UTC (permalink / raw)
To: Michael Snyder; +Cc: Elena Zannoni, Daniel Jacobowitz, gdb-patches
Michael Snyder writes:
> Elena Zannoni wrote:
> >
> > Daniel Jacobowitz writes:
> > > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > > > Elena Zannoni writes:
> > > > >
> > > > > I hope this is the last of the AltiVec series.
> > > > >
> > > > > Elena
> > > > >
> > > > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > > > >
> > > > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > > > we are dealing with vectors.
> > > > >
> > > > >
> > > >
> > > > I committed this, given that the file seems unmaintained.
> > >
> > > FYI, I was told that the value support files are all considered
> > > "language support" and require explicit approval from a blanket write
> > > maintainer.
> > >
> >
> > I am such a maintainer.
>
> Oops -- this was supposed to be a reply to Elena's post. >;-)
>
>
> In place of a Dark Lord you would have a QUEEN!!
> And I shall not be dark but beautiful and terrible to behold!!
> Fair as the Sea and the Sun and the Snow upon the Mountain!!
> Dreaful as the Storm and Lightning!! Stronger than the
> foundations of the earth!! All shall love me and despair!!
Oh dear, is this the Queen of the Borg???
Elena
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 17:36 ` Elena Zannoni
@ 2002-05-02 17:51 ` Michael Snyder
2002-05-02 18:00 ` Elena Zannoni
0 siblings, 1 reply; 10+ messages in thread
From: Michael Snyder @ 2002-05-02 17:51 UTC (permalink / raw)
To: Elena Zannoni; +Cc: Daniel Jacobowitz, gdb-patches
Elena Zannoni wrote:
>
> Michael Snyder writes:
> > Elena Zannoni wrote:
> > >
> > > Daniel Jacobowitz writes:
> > > > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > > > > Elena Zannoni writes:
> > > > > >
> > > > > > I hope this is the last of the AltiVec series.
> > > > > >
> > > > > > Elena
> > > > > >
> > > > > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > > > > >
> > > > > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > > > > we are dealing with vectors.
> > > > > >
> > > > > >
> > > > >
> > > > > I committed this, given that the file seems unmaintained.
> > > >
> > > > FYI, I was told that the value support files are all considered
> > > > "language support" and require explicit approval from a blanket write
> > > > maintainer.
> > > >
> > >
> > > I am such a maintainer.
> >
> > Oops -- this was supposed to be a reply to Elena's post. >;-)
> >
> >
> > In place of a Dark Lord you would have a QUEEN!!
> > And I shall not be dark but beautiful and terrible to behold!!
> > Fair as the Sea and the Sun and the Snow upon the Mountain!!
> > Dreaful as the Storm and Lightning!! Stronger than the
> > foundations of the earth!! All shall love me and despair!!
>
> Oh dear, is this the Queen of the Borg???
Awwwwww -- No! It's from LOTR! It's Galadriel's show-stealing scene!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 17:51 ` Michael Snyder
@ 2002-05-02 18:00 ` Elena Zannoni
0 siblings, 0 replies; 10+ messages in thread
From: Elena Zannoni @ 2002-05-02 18:00 UTC (permalink / raw)
To: Michael Snyder; +Cc: Elena Zannoni, Daniel Jacobowitz, gdb-patches
Michael Snyder writes:
> Elena Zannoni wrote:
> >
> > Michael Snyder writes:
> > > Elena Zannoni wrote:
> > > >
> > > > Daniel Jacobowitz writes:
> > > > > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > > > > > Elena Zannoni writes:
> > > > > > >
> > > > > > > I hope this is the last of the AltiVec series.
> > > > > > >
> > > > > > > Elena
> > > > > > >
> > > > > > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > > > > > >
> > > > > > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > > > > > we are dealing with vectors.
> > > > > > >
> > > > > > >
> > > > > >
> > > > > > I committed this, given that the file seems unmaintained.
> > > > >
> > > > > FYI, I was told that the value support files are all considered
> > > > > "language support" and require explicit approval from a blanket write
> > > > > maintainer.
> > > > >
> > > >
> > > > I am such a maintainer.
> > >
> > > Oops -- this was supposed to be a reply to Elena's post. >;-)
> > >
> > >
> > > In place of a Dark Lord you would have a QUEEN!!
> > > And I shall not be dark but beautiful and terrible to behold!!
> > > Fair as the Sea and the Sun and the Snow upon the Mountain!!
> > > Dreaful as the Storm and Lightning!! Stronger than the
> > > foundations of the earth!! All shall love me and despair!!
> >
> > Oh dear, is this the Queen of the Borg???
>
> Awwwwww -- No! It's from LOTR! It's Galadriel's show-stealing scene!
D'oh! Argh. By that scene I was already asleep! :-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
2002-05-02 12:08 ` Daniel Jacobowitz
2002-05-02 12:19 ` Elena Zannoni
@ 2002-05-02 14:21 ` Michael Snyder
1 sibling, 0 replies; 10+ messages in thread
From: Michael Snyder @ 2002-05-02 14:21 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Daniel Jacobowitz wrote:
>
> On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > Elena Zannoni writes:
> > >
> > > I hope this is the last of the AltiVec series.
> > >
> > > Elena
> > >
> > > 2002-04-29 Elena Zannoni <ezannoni@redhat.com>
> > >
> > > * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> > > we are dealing with vectors.
> > >
> > >
> >
> > I committed this, given that the file seems unmaintained.
>;-)
[-- Attachment #2: tmp --]
[-- Type: text/plain, Size: 292 bytes --]
In place of a Dark Lord you would have a QUEEN!!
And I shall not be dark but beautiful and terrible to behold!!
Fair as the Sea and the Sun and the Snow upon the Mountain!!
Dreaful as the Storm and Lightning!! Stronger than the
foundations of the earth!! All shall love me and despair!!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFA] valops.c: don't coerce vectors.
@ 2002-05-02 18:12 Michael Elizabeth Chastain
0 siblings, 0 replies; 10+ messages in thread
From: Michael Elizabeth Chastain @ 2002-05-02 18:12 UTC (permalink / raw)
To: ezannoni, msnyder; +Cc: drow, gdb-patches
I'm not worried about Michael Snyder's signature, but if that quote
starts showing up in Elena's posts ... um, well, I'll just quietly
move all HER submissions to the front of my work queue! Or something.
Michael C
"love without fear"
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2002-05-03 1:12 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-29 14:47 [RFA] valops.c: don't coerce vectors Elena Zannoni
2002-05-02 12:04 ` Elena Zannoni
2002-05-02 12:08 ` Daniel Jacobowitz
2002-05-02 12:19 ` Elena Zannoni
2002-05-02 14:45 ` Michael Snyder
2002-05-02 17:36 ` Elena Zannoni
2002-05-02 17:51 ` Michael Snyder
2002-05-02 18:00 ` Elena Zannoni
2002-05-02 14:21 ` Michael Snyder
2002-05-02 18:12 Michael Elizabeth Chastain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox