[RFA] valops.c: don't coerce vectors.

[RFA] valops.c: don't coerce vectors.

[Elena Zannoni]

I hope this is the last of the AltiVec series.

Elena

2002-04-29  Elena Zannoni  <ezannoni@redhat.com>

	* valops.c (value_arg_coerce): Don't coerce arrays to pointers if
	we are dealing with vectors.


Index: valops.c
===================================================================
RCS file: /cvs/uberbaum/gdb/valops.c,v
retrieving revision 1.55
diff -u -p -r1.55 valops.c
--- valops.c	26 Apr 2002 03:37:42 -0000	1.55
+++ valops.c	29 Apr 2002 21:45:55 -0000
@@ -1190,8 +1190,12 @@ value_arg_coerce (struct value *arg, str
       type = lookup_pointer_type (type);
       break;
     case TYPE_CODE_ARRAY:
+      /* Arrays are coerced to pointers to their first element, unless
+         they are vectors, in which case we want to leave them alone,
+         because they are passed by value.  */
       if (current_language->c_style_arrays)
-	type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
+	if (!TYPE_VECTOR (type))
+	  type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
       break;
     case TYPE_CODE_UNDEF:
     case TYPE_CODE_PTR:

Re: [RFA] valops.c: don't coerce vectors.

[Elena Zannoni]

Elena Zannoni writes:
 > 
 > I hope this is the last of the AltiVec series.
 > 
 > Elena
 > 
 > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
 > 
 > 	* valops.c (value_arg_coerce): Don't coerce arrays to pointers if
 > 	we are dealing with vectors.
 > 
 > 

I committed this, given that the file seems unmaintained.

Elena


 > Index: valops.c
 > ===================================================================
 > RCS file: /cvs/uberbaum/gdb/valops.c,v
 > retrieving revision 1.55
 > diff -u -p -r1.55 valops.c
 > --- valops.c	26 Apr 2002 03:37:42 -0000	1.55
 > +++ valops.c	29 Apr 2002 21:45:55 -0000
 > @@ -1190,8 +1190,12 @@ value_arg_coerce (struct value *arg, str
 >        type = lookup_pointer_type (type);
 >        break;
 >      case TYPE_CODE_ARRAY:
 > +      /* Arrays are coerced to pointers to their first element, unless
 > +         they are vectors, in which case we want to leave them alone,
 > +         because they are passed by value.  */
 >        if (current_language->c_style_arrays)
 > -	type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
 > +	if (!TYPE_VECTOR (type))
 > +	  type = lookup_pointer_type (TYPE_TARGET_TYPE (type));
 >        break;
 >      case TYPE_CODE_UNDEF:
 >      case TYPE_CODE_PTR:

Re: [RFA] valops.c: don't coerce vectors.

[Daniel Jacobowitz]

On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> Elena Zannoni writes:
>  > 
>  > I hope this is the last of the AltiVec series.
>  > 
>  > Elena
>  > 
>  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
>  > 
>  > 	* valops.c (value_arg_coerce): Don't coerce arrays to pointers if
>  > 	we are dealing with vectors.
>  > 
>  > 
> 
> I committed this, given that the file seems unmaintained.

FYI, I was told that the value support files are all considered
"language support" and require explicit approval from a blanket write
maintainer.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] valops.c: don't coerce vectors.

[Elena Zannoni]

Daniel Jacobowitz writes:
 > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
 > > Elena Zannoni writes:
 > >  > 
 > >  > I hope this is the last of the AltiVec series.
 > >  > 
 > >  > Elena
 > >  > 
 > >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
 > >  > 
 > >  > 	* valops.c (value_arg_coerce): Don't coerce arrays to pointers if
 > >  > 	we are dealing with vectors.
 > >  > 
 > >  > 
 > > 
 > > I committed this, given that the file seems unmaintained.
 > 
 > FYI, I was told that the value support files are all considered
 > "language support" and require explicit approval from a blanket write
 > maintainer.
 > 

I am such a maintainer.

Elena


 > -- 
 > Daniel Jacobowitz                           Carnegie Mellon University
 > MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] valops.c: don't coerce vectors.

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Daniel Jacobowitz wrote:
> 
> On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
> > Elena Zannoni writes:
> >  >
> >  > I hope this is the last of the AltiVec series.
> >  >
> >  > Elena
> >  >
> >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
> >  >
> >  >    * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
> >  >    we are dealing with vectors.
> >  >
> >  >
> >
> > I committed this, given that the file seems unmaintained.

>;-)

[-- Attachment #2: tmp --]
[-- Type: text/plain, Size: 292 bytes --]

In place of a Dark Lord you would have a QUEEN!! 
And I shall not be dark but beautiful and terrible to behold!! 
Fair as the Sea and the Sun and the Snow upon the Mountain!!
Dreaful as the Storm and Lightning!! Stronger than the 
foundations  of the earth!!  All shall love me and despair!!

Re: [RFA] valops.c: don't coerce vectors.

[Michael Snyder]

Elena Zannoni wrote:
> 
> Daniel Jacobowitz writes:
>  > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
>  > > Elena Zannoni writes:
>  > >  >
>  > >  > I hope this is the last of the AltiVec series.
>  > >  >
>  > >  > Elena
>  > >  >
>  > >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
>  > >  >
>  > >  >         * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
>  > >  >         we are dealing with vectors.
>  > >  >
>  > >  >
>  > >
>  > > I committed this, given that the file seems unmaintained.
>  >
>  > FYI, I was told that the value support files are all considered
>  > "language support" and require explicit approval from a blanket write
>  > maintainer.
>  >
> 
> I am such a maintainer.

Oops -- this was supposed to be a reply to Elena's post.   >;-)


In place of a Dark Lord you would have a QUEEN!! 
And I shall not be dark but beautiful and terrible to behold!! 
Fair as the Sea and the Sun and the Snow upon the Mountain!!
Dreaful as the Storm and Lightning!! Stronger than the 
foundations  of the earth!!  All shall love me and despair!!

Re: [RFA] valops.c: don't coerce vectors.

[Elena Zannoni]

Michael Snyder writes:
 > Elena Zannoni wrote:
 > > 
 > > Daniel Jacobowitz writes:
 > >  > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
 > >  > > Elena Zannoni writes:
 > >  > >  >
 > >  > >  > I hope this is the last of the AltiVec series.
 > >  > >  >
 > >  > >  > Elena
 > >  > >  >
 > >  > >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
 > >  > >  >
 > >  > >  >         * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
 > >  > >  >         we are dealing with vectors.
 > >  > >  >
 > >  > >  >
 > >  > >
 > >  > > I committed this, given that the file seems unmaintained.
 > >  >
 > >  > FYI, I was told that the value support files are all considered
 > >  > "language support" and require explicit approval from a blanket write
 > >  > maintainer.
 > >  >
 > > 
 > > I am such a maintainer.
 > 
 > Oops -- this was supposed to be a reply to Elena's post.   >;-)
 > 
 > 
 > In place of a Dark Lord you would have a QUEEN!! 
 > And I shall not be dark but beautiful and terrible to behold!! 
 > Fair as the Sea and the Sun and the Snow upon the Mountain!!
 > Dreaful as the Storm and Lightning!! Stronger than the 
 > foundations  of the earth!!  All shall love me and despair!!



Oh dear, is this the Queen of the Borg???

Elena

Re: [RFA] valops.c: don't coerce vectors.

[Michael Snyder]

Elena Zannoni wrote:
> 
> Michael Snyder writes:
>  > Elena Zannoni wrote:
>  > >
>  > > Daniel Jacobowitz writes:
>  > >  > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
>  > >  > > Elena Zannoni writes:
>  > >  > >  >
>  > >  > >  > I hope this is the last of the AltiVec series.
>  > >  > >  >
>  > >  > >  > Elena
>  > >  > >  >
>  > >  > >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
>  > >  > >  >
>  > >  > >  >         * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
>  > >  > >  >         we are dealing with vectors.
>  > >  > >  >
>  > >  > >  >
>  > >  > >
>  > >  > > I committed this, given that the file seems unmaintained.
>  > >  >
>  > >  > FYI, I was told that the value support files are all considered
>  > >  > "language support" and require explicit approval from a blanket write
>  > >  > maintainer.
>  > >  >
>  > >
>  > > I am such a maintainer.
>  >
>  > Oops -- this was supposed to be a reply to Elena's post.   >;-)
>  >
>  >
>  > In place of a Dark Lord you would have a QUEEN!!
>  > And I shall not be dark but beautiful and terrible to behold!!
>  > Fair as the Sea and the Sun and the Snow upon the Mountain!!
>  > Dreaful as the Storm and Lightning!! Stronger than the
>  > foundations  of the earth!!  All shall love me and despair!!
> 
> Oh dear, is this the Queen of the Borg???

Awwwwww --  No!  It's from LOTR!  It's Galadriel's show-stealing scene!

Re: [RFA] valops.c: don't coerce vectors.

[Elena Zannoni]

Michael Snyder writes:
 > Elena Zannoni wrote:
 > > 
 > > Michael Snyder writes:
 > >  > Elena Zannoni wrote:
 > >  > >
 > >  > > Daniel Jacobowitz writes:
 > >  > >  > On Thu, May 02, 2002 at 03:00:15PM -0400, Elena Zannoni wrote:
 > >  > >  > > Elena Zannoni writes:
 > >  > >  > >  >
 > >  > >  > >  > I hope this is the last of the AltiVec series.
 > >  > >  > >  >
 > >  > >  > >  > Elena
 > >  > >  > >  >
 > >  > >  > >  > 2002-04-29  Elena Zannoni  <ezannoni@redhat.com>
 > >  > >  > >  >
 > >  > >  > >  >         * valops.c (value_arg_coerce): Don't coerce arrays to pointers if
 > >  > >  > >  >         we are dealing with vectors.
 > >  > >  > >  >
 > >  > >  > >  >
 > >  > >  > >
 > >  > >  > > I committed this, given that the file seems unmaintained.
 > >  > >  >
 > >  > >  > FYI, I was told that the value support files are all considered
 > >  > >  > "language support" and require explicit approval from a blanket write
 > >  > >  > maintainer.
 > >  > >  >
 > >  > >
 > >  > > I am such a maintainer.
 > >  >
 > >  > Oops -- this was supposed to be a reply to Elena's post.   >;-)
 > >  >
 > >  >
 > >  > In place of a Dark Lord you would have a QUEEN!!
 > >  > And I shall not be dark but beautiful and terrible to behold!!
 > >  > Fair as the Sea and the Sun and the Snow upon the Mountain!!
 > >  > Dreaful as the Storm and Lightning!! Stronger than the
 > >  > foundations  of the earth!!  All shall love me and despair!!
 > > 
 > > Oh dear, is this the Queen of the Borg???
 > 
 > Awwwwww --  No!  It's from LOTR!  It's Galadriel's show-stealing scene!

D'oh! Argh. By that scene I was already asleep! :-)

Re: [RFA] valops.c: don't coerce vectors.

[Michael Elizabeth Chastain]

I'm not worried about Michael Snyder's signature, but if that quote
starts showing up in Elena's posts ... um, well, I'll just quietly
move all HER submissions to the front of my work queue!  Or something.

Michael C
"love without fear"