* RFA: properly skip interrupts.exp
@ 2002-03-01 15:10 Jim Blandy
2002-06-20 11:25 ` Jim Blandy
0 siblings, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2002-03-01 15:10 UTC (permalink / raw)
To: gdb-patches
2002-03-01 Jim Blandy <jimb@redhat.com>
* gdb.base/interrupt.exp: Correct logic for skipping tests on
targets that don't support interrupts.
Index: gdb/testsuite/gdb.base/interrupt.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/interrupt.exp,v
retrieving revision 1.36
diff -c -r1.36 interrupt.exp
*** gdb/testsuite/gdb.base/interrupt.exp 2001/10/31 18:28:27 1.36
--- gdb/testsuite/gdb.base/interrupt.exp 2002/03/01 22:24:08
***************
*** 18,28 ****
# Please email any bugs, comments, and/or additions to this file to:
# bug-gdb@prep.ai.mit.edu
! if [host_info exists name] {
! if [board_info host exists gdb,nointerrupts] {
! verbose "Skipping interrupt.exp because of nointerrupts."
! continue
! }
}
if [target_info exists gdb,noinferiorio] {
--- 18,26 ----
# Please email any bugs, comments, and/or additions to this file to:
# bug-gdb@prep.ai.mit.edu
! if [target_info exists gdb,nointerrupts] {
! verbose "Skipping interrupt.exp because of nointerrupts."
! continue
}
if [target_info exists gdb,noinferiorio] {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RFA: properly skip interrupts.exp
2002-03-01 15:10 RFA: properly skip interrupts.exp Jim Blandy
@ 2002-06-20 11:25 ` Jim Blandy
2002-07-12 16:22 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2002-06-20 11:25 UTC (permalink / raw)
To: gdb-patches
Ping to testsuite maintainer: this patch needs review.
Jim Blandy <jimb@redhat.com> writes:
> 2002-03-01 Jim Blandy <jimb@redhat.com>
>
> * gdb.base/interrupt.exp: Correct logic for skipping tests on
> targets that don't support interrupts.
>
> Index: gdb/testsuite/gdb.base/interrupt.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/interrupt.exp,v
> retrieving revision 1.36
> diff -c -r1.36 interrupt.exp
> *** gdb/testsuite/gdb.base/interrupt.exp 2001/10/31 18:28:27 1.36
> --- gdb/testsuite/gdb.base/interrupt.exp 2002/03/01 22:24:08
> ***************
> *** 18,28 ****
> # Please email any bugs, comments, and/or additions to this file to:
> # bug-gdb@prep.ai.mit.edu
>
> ! if [host_info exists name] {
> ! if [board_info host exists gdb,nointerrupts] {
> ! verbose "Skipping interrupt.exp because of nointerrupts."
> ! continue
> ! }
> }
>
> if [target_info exists gdb,noinferiorio] {
> --- 18,26 ----
> # Please email any bugs, comments, and/or additions to this file to:
> # bug-gdb@prep.ai.mit.edu
>
> ! if [target_info exists gdb,nointerrupts] {
> ! verbose "Skipping interrupt.exp because of nointerrupts."
> ! continue
> }
>
> if [target_info exists gdb,noinferiorio] {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RFA: properly skip interrupts.exp
2002-06-20 11:25 ` Jim Blandy
@ 2002-07-12 16:22 ` Andrew Cagney
2002-07-18 17:02 ` Jim Blandy
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-07-12 16:22 UTC (permalink / raw)
To: Jim Blandy, Fernando Nasser; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
> 2002-03-01 Jim Blandy <jimb@redhat.com>
>>
>> * gdb.base/interrupt.exp: Correct logic for skipping tests on
>> targets that don't support interrupts.
>>
>>
Yep, ok (this one I'm sure of).
Andrew
[-- Attachment #2: mailbox-message://ac131313@movemail/fsf/gdb/patches/sep#3195744 --]
[-- Type: message/rfc822, Size: 3562 bytes --]
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: RFA: properly skip interrupts.exp
Date: 20 Jun 2002 13:25:14 -0500
Message-ID: <npofe5x0xh.fsf@zwingli.cygnus.com>
Ping to testsuite maintainer: this patch needs review.
Jim Blandy <jimb@redhat.com> writes:
> 2002-03-01 Jim Blandy <jimb@redhat.com>
>
> * gdb.base/interrupt.exp: Correct logic for skipping tests on
> targets that don't support interrupts.
>
> Index: gdb/testsuite/gdb.base/interrupt.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/interrupt.exp,v
> retrieving revision 1.36
> diff -c -r1.36 interrupt.exp
> *** gdb/testsuite/gdb.base/interrupt.exp 2001/10/31 18:28:27 1.36
> --- gdb/testsuite/gdb.base/interrupt.exp 2002/03/01 22:24:08
> ***************
> *** 18,28 ****
> # Please email any bugs, comments, and/or additions to this file to:
> # bug-gdb@prep.ai.mit.edu
>
> ! if [host_info exists name] {
> ! if [board_info host exists gdb,nointerrupts] {
> ! verbose "Skipping interrupt.exp because of nointerrupts."
> ! continue
> ! }
> }
>
> if [target_info exists gdb,noinferiorio] {
> --- 18,26 ----
> # Please email any bugs, comments, and/or additions to this file to:
> # bug-gdb@prep.ai.mit.edu
>
> ! if [target_info exists gdb,nointerrupts] {
> ! verbose "Skipping interrupt.exp because of nointerrupts."
> ! continue
> }
>
> if [target_info exists gdb,noinferiorio] {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: RFA: properly skip interrupts.exp
2002-07-12 16:22 ` Andrew Cagney
@ 2002-07-18 17:02 ` Jim Blandy
0 siblings, 0 replies; 6+ messages in thread
From: Jim Blandy @ 2002-07-18 17:02 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Fernando Nasser, gdb-patches
Committed, thanks.
Andrew Cagney <ac131313@ges.redhat.com> writes:
> > 2002-03-01 Jim Blandy <jimb@redhat.com>
> >> * gdb.base/interrupt.exp: Correct logic for skipping tests on
> >> targets that don't support interrupts.
> >>
> Yep, ok (this one I'm sure of).
>
> Andrew
>
> From: Jim Blandy <jimb@redhat.com>
> Subject: Re: RFA: properly skip interrupts.exp
> To: gdb-patches@sources.redhat.com
> Date: 20 Jun 2002 13:25:14 -0500
>
>
> Ping to testsuite maintainer: this patch needs review.
>
> Jim Blandy <jimb@redhat.com> writes:
>
> > 2002-03-01 Jim Blandy <jimb@redhat.com>
> >
> > * gdb.base/interrupt.exp: Correct logic for skipping tests on
> > targets that don't support interrupts.
> >
> > Index: gdb/testsuite/gdb.base/interrupt.exp
> > ===================================================================
> > RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/interrupt.exp,v
> > retrieving revision 1.36
> > diff -c -r1.36 interrupt.exp
> > *** gdb/testsuite/gdb.base/interrupt.exp 2001/10/31 18:28:27 1.36
> > --- gdb/testsuite/gdb.base/interrupt.exp 2002/03/01 22:24:08
> > ***************
> > *** 18,28 ****
> > # Please email any bugs, comments, and/or additions to this file to:
> > # bug-gdb@prep.ai.mit.edu
> >
> > ! if [host_info exists name] {
> > ! if [board_info host exists gdb,nointerrupts] {
> > ! verbose "Skipping interrupt.exp because of nointerrupts."
> > ! continue
> > ! }
> > }
> >
> > if [target_info exists gdb,noinferiorio] {
> > --- 18,26 ----
> > # Please email any bugs, comments, and/or additions to this file to:
> > # bug-gdb@prep.ai.mit.edu
> >
> > ! if [target_info exists gdb,nointerrupts] {
> > ! verbose "Skipping interrupt.exp because of nointerrupts."
> > ! continue
> > }
> >
> > if [target_info exists gdb,noinferiorio] {
>
> ----------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: properly skip interrupts.exp
@ 2002-03-01 21:45 Michael Elizabeth Chastain
2002-03-04 18:27 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Michael Elizabeth Chastain @ 2002-03-01 21:45 UTC (permalink / raw)
To: gdb-patches, jimb
I have doubts about this. It seems plausible to me that "nointerrupts"
is a property of the host, not the target. gdb.base/interrupt.exp
seems very host oriented to me.
But dejagnu 1.4.2 has just two boards that set this:
baseboards.exp/dos.exp
baseboards.exp/m68hc11-sim.exp
I don't really know whether host or target is correct, and I don't
know what will happen with a switch. Sigh.
I'm inclined to rip out "nointerrupts", rip out the years of
"setup_xfail" crud, and let the FAILs fall where they may.
But not with the 5.2 branch and 5.2 release imminent.
Michael C
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: properly skip interrupts.exp
2002-03-01 21:45 Michael Elizabeth Chastain
@ 2002-03-04 18:27 ` Andrew Cagney
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Cagney @ 2002-03-04 18:27 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: gdb-patches, jimb
> I have doubts about this. It seems plausible to me that "nointerrupts"
> is a property of the host, not the target. gdb.base/interrupt.exp
> seems very host oriented to me.
I think it is a target vector property. It is just that few targets
(beyond native) think to implement the functionality described by
interrupt.exp.
Things get confusing when you find that certain target interfaces don't
work on certain hosts.
> But dejagnu 1.4.2 has just two boards that set this:
>
> baseboards.exp/dos.exp
> baseboards.exp/m68hc11-sim.exp
>
> I don't really know whether host or target is correct, and I don't
> know what will happen with a switch. Sigh.
>
> I'm inclined to rip out "nointerrupts", rip out the years of
> "setup_xfail" crud, and let the FAILs fall where they may.
> But not with the 5.2 branch and 5.2 release imminent.
Not sure about nointerrupts, pulling the setup_xfail cruft sounds positive.
enjoy,
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-07-18 23:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-01 15:10 RFA: properly skip interrupts.exp Jim Blandy
2002-06-20 11:25 ` Jim Blandy
2002-07-12 16:22 ` Andrew Cagney
2002-07-18 17:02 ` Jim Blandy
2002-03-01 21:45 Michael Elizabeth Chastain
2002-03-04 18:27 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox