Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com
Subject: Re: Infinite loop in make_cv_type
Date: Fri, 22 Feb 2002 11:45:00 -0000	[thread overview]
Message-ID: <200202221944.TAA09969@cam-mail2.cambridge.arm.com> (raw)
In-Reply-To: Your message of "Fri, 22 Feb 2002 19:06:48 GMT." <200202221906.TAA07621@cam-mail2.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]


> Any suggestions as to how the stabs reader might be getting ahead of 
> itself?  Is there another function that might be returning the stabs 
> string?  I don't think dbx_next_symbol_text has ever returned this 
> earlier...

Dead simple really.  The stabs on the ARM are broken into very short 
strings for historical reasons (there was once an assembler that couldn't 
cope with stabs strings of more than about 100 characters).  We are simply 
running off the end of a stabs string without calling STABS_CONTINUE.  
Thus we end up parsing the following string twice: once on the overrun and 
the second when dbx_next_symbol_text returns it.

OK to apply?

R.

<date>  Richard Earnshaw  (rearnsha@arm.com)

	* stabsread.c (read_member_functions): Call STABS_CONTINUE after 
	skipping a method.



[-- Attachment #2: gdb-stab.patch --]
[-- Type: text/x-patch , Size: 445 bytes --]

Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.27
diff -p -r1.27 stabsread.c
*** stabsread.c	2002/02/20 18:40:52	1.27
--- stabsread.c	2002/02/22 19:39:29
*************** read_member_functions (struct field_info
*** 3104,3109 ****
--- 3104,3110 ----
  	    (*pp) ++;
  	  (*pp) ++;
  
+ 	  STABS_CONTINUE (pp, objfile);
  	  continue;
  	}
  

  reply	other threads:[~2002-02-22 19:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22  3:41 Richard Earnshaw
2002-02-22  7:55 ` Daniel Jacobowitz
2002-02-22  9:24   ` Michael Snyder
2002-02-22  9:41     ` Richard Earnshaw
2002-02-22 10:33     ` Daniel Jacobowitz
2002-02-22 10:22   ` Richard Earnshaw
2002-02-22 10:38     ` Daniel Jacobowitz
2002-02-22 10:46       ` Richard Earnshaw
2002-02-22 11:07         ` Richard Earnshaw
2002-02-22 11:45           ` Richard Earnshaw [this message]
2002-02-22 11:52             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200202221944.TAA09969@cam-mail2.cambridge.arm.com \
    --to=rearnsha@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox