Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Infinite loop in make_cv_type
Date: Fri, 22 Feb 2002 11:52:00 -0000	[thread overview]
Message-ID: <20020222145223.A22015@nevyn.them.org> (raw)
In-Reply-To: <200202221944.TAA09969@cam-mail2.cambridge.arm.com>

On Fri, Feb 22, 2002 at 07:44:44PM +0000, Richard Earnshaw wrote:
> 
> > Any suggestions as to how the stabs reader might be getting ahead of 
> > itself?  Is there another function that might be returning the stabs 
> > string?  I don't think dbx_next_symbol_text has ever returned this 
> > earlier...
> 
> Dead simple really.  The stabs on the ARM are broken into very short 
> strings for historical reasons (there was once an assembler that couldn't 
> cope with stabs strings of more than about 100 characters).  We are simply 
> running off the end of a stabs string without calling STABS_CONTINUE.  
> Thus we end up parsing the following string twice: once on the overrun and 
> the second when dbx_next_symbol_text returns it.
> 
> OK to apply?
> 
> R.
> 
> <date>  Richard Earnshaw  (rearnsha@arm.com)
> 
> 	* stabsread.c (read_member_functions): Call STABS_CONTINUE after 
> 	skipping a method.
> 
> 

My fault, it figures.  I've never been clear when STABS_CONTINUE is
actually necessary.  I can't approve it, but this looks good to me.

The rest of the problems you found should be fixed, but are not urgent;
I'll try to get to gdb/277 in the next few weeks...

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2002-02-22 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22  3:41 Richard Earnshaw
2002-02-22  7:55 ` Daniel Jacobowitz
2002-02-22  9:24   ` Michael Snyder
2002-02-22  9:41     ` Richard Earnshaw
2002-02-22 10:33     ` Daniel Jacobowitz
2002-02-22 10:22   ` Richard Earnshaw
2002-02-22 10:38     ` Daniel Jacobowitz
2002-02-22 10:46       ` Richard Earnshaw
2002-02-22 11:07         ` Richard Earnshaw
2002-02-22 11:45           ` Richard Earnshaw
2002-02-22 11:52             ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020222145223.A22015@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox