From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2161 invoked by alias); 22 Feb 2002 19:45:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1916 invoked from network); 22 Feb 2002 19:45:36 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 22 Feb 2002 19:45:36 -0000 Received: by fw-cam.cambridge.arm.com; id TAA05284; Fri, 22 Feb 2002 19:45:35 GMT Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma004582; Fri, 22 Feb 02 19:44:45 GMT Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id TAA10923; Fri, 22 Feb 2002 19:44:44 GMT Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id TAA09969; Fri, 22 Feb 2002 19:44:44 GMT Message-Id: <200202221944.TAA09969@cam-mail2.cambridge.arm.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Daniel Jacobowitz cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: Re: Infinite loop in make_cv_type In-reply-to: Your message of "Fri, 22 Feb 2002 19:06:48 GMT." <200202221906.TAA07621@cam-mail2.cambridge.arm.com> Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_1321726720" Date: Fri, 22 Feb 2002 11:45:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-02/txt/msg00629.txt.bz2 This is a multipart MIME message. --==_Exmh_1321726720 Content-Type: text/plain; charset=us-ascii Content-length: 801 > Any suggestions as to how the stabs reader might be getting ahead of > itself? Is there another function that might be returning the stabs > string? I don't think dbx_next_symbol_text has ever returned this > earlier... Dead simple really. The stabs on the ARM are broken into very short strings for historical reasons (there was once an assembler that couldn't cope with stabs strings of more than about 100 characters). We are simply running off the end of a stabs string without calling STABS_CONTINUE. Thus we end up parsing the following string twice: once on the overrun and the second when dbx_next_symbol_text returns it. OK to apply? R. Richard Earnshaw (rearnsha@arm.com) * stabsread.c (read_member_functions): Call STABS_CONTINUE after skipping a method. --==_Exmh_1321726720 Content-Type: text/x-patch ; name="gdb-stab.patch"; charset=us-ascii Content-Description: gdb-stab.patch Content-Disposition: attachment; filename="gdb-stab.patch" Content-length: 445 Index: stabsread.c =================================================================== RCS file: /cvs/src/src/gdb/stabsread.c,v retrieving revision 1.27 diff -p -r1.27 stabsread.c *** stabsread.c 2002/02/20 18:40:52 1.27 --- stabsread.c 2002/02/22 19:39:29 *************** read_member_functions (struct field_info *** 3104,3109 **** --- 3104,3110 ---- (*pp) ++; (*pp) ++; + STABS_CONTINUE (pp, objfile); continue; } --==_Exmh_1321726720--