Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: ac131313@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa:testsuite} Overhaul sizeof.exp
Date: Tue, 19 Feb 2002 15:46:00 -0000	[thread overview]
Message-ID: <200202192346.g1JNk6730384@duracef.shout.net> (raw)

A nit: there is an extraneous change to call-ar-st.exp.

Bigger nit: the ChangeLog says that it's about sizeof.exp, but the patch
includes changes to sizeof.c.

The real feedback: I threw it in the native i686-pc-linux-gnu test bed
for a quick before-and-after,   Nothing broke, but one of the
the new tests FAILs in all configurations.

  FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-dwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-dwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gstabs+

Here is a log excerpt:

  # target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
  print padding_long_double.p1^M
  $35 = "The quick brown "^M
  (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p1
  print/d padding_long_double.v = 4^M
  $36 = 2523330444660750855469793280^M
  (gdb) FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
  print padding_long_double.p2^M
  $37 = "The quick brown "^M
  (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p2

All 10 gdb.log files have the same constant value for $36.

Michael C


             reply	other threads:[~2002-02-19 23:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-19 15:46 Michael Elizabeth Chastain [this message]
2002-02-19 18:19 ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2002-02-20 10:24 Michael Elizabeth Chastain
2002-02-20 11:48 ` Fernando Nasser
2002-02-20  9:49 Michael Elizabeth Chastain
2002-02-20 10:06 ` Fernando Nasser
2002-02-20 10:12   ` Daniel Jacobowitz
2002-02-20 10:07 ` Daniel Jacobowitz
2002-02-20 10:18   ` Fernando Nasser
2002-02-20 10:07 ` Richard Earnshaw
2002-02-20  9:17 Michael Elizabeth Chastain
2002-02-20  9:42 ` Fernando Nasser
2002-02-20 10:20 ` Andrew Cagney
2002-02-20  8:59 Michael Elizabeth Chastain
2002-02-19 20:57 Michael Elizabeth Chastain
2002-02-20  6:57 ` Andrew Cagney
2002-02-20  7:21   ` Andrew Cagney
2002-02-20  8:19     ` Fernando Nasser
2002-02-20 17:57       ` Andrew Cagney
2002-02-20  8:16   ` Fernando Nasser
2002-02-20  8:51     ` Daniel Jacobowitz
2002-02-20  9:24       ` Fernando Nasser
2002-02-21 14:04       ` Jim Blandy
2002-02-21 14:23         ` Daniel Jacobowitz
2002-02-19 20:43 Michael Elizabeth Chastain
2002-02-21 14:03 ` Jim Blandy
2002-02-19 15:17 Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200202192346.g1JNk6730384@duracef.shout.net \
    --to=mec@shout.net \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox