From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12898-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 11466 invoked by alias); 19 Feb 2002 23:46:12 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 11367 invoked from network); 19 Feb 2002 23:46:11 -0000
Received: from unknown (HELO duracef.shout.net) (204.253.184.12)
  by sources.redhat.com with SMTP; 19 Feb 2002 23:46:11 -0000
Received: (from mec@localhost)
	by duracef.shout.net (8.11.6/8.11.6) id g1JNk6730384;
	Tue, 19 Feb 2002 17:46:06 -0600
Date: Tue, 19 Feb 2002 15:46:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200202192346.g1JNk6730384@duracef.shout.net>
To: ac131313@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa:testsuite} Overhaul sizeof.exp
X-SW-Source: 2002-02/txt/msg00513.txt.bz2

A nit: there is an extraneous change to call-ar-st.exp.

Bigger nit: the ChangeLog says that it's about sizeof.exp, but the patch
includes changes to sizeof.c.

The real feedback: I threw it in the native i686-pc-linux-gnu test bed
for a quick before-and-after,   Nothing broke, but one of the
the new tests FAILs in all configurations.

  FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=2.95.3, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gdwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.4-20020215, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-dwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=gcc-3_0-branch%2002-02-16, goption=-gstabs+
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-dwarf-2
    target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=HEAD%2002-02-16, goption=-gstabs+

Here is a log excerpt:

  # target=native, host=i686-pc-linux-gnu%rh-7.2, gdb=HEAD%2002-02-16, gcc=3.0.3, goption=-gstabs+
  print padding_long_double.p1^M
  $35 = "The quick brown "^M
  (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p1
  print/d padding_long_double.v = 4^M
  $36 = 2523330444660750855469793280^M
  (gdb) FAIL: gdb.base/sizeof.exp: print/d padding_long_double.v = 4
  print padding_long_double.p2^M
  $37 = "The quick brown "^M
  (gdb) PASS: gdb.base/sizeof.exp: print padding_long_double.p2

All 10 gdb.log files have the same constant value for $36.

Michael C