linespec.c:cplusplus_hint()?

linespec.c:cplusplus_hint()?

[Andrew Cagney]

Hello,

I'm wondering if the function:

/* While the C++ support is still in flux, issue a possibly helpful hint on
    using the new command completion feature on single quoted demangled C++
    symbols.  Remove when loose ends are cleaned up.   FIXME -fnf */

static void
cplusplus_hint (char *name)
{
   while (*name == '\'')
     name++;
   printf_filtered ("Hint: try '%s<TAB> or '%s<ESC-?>\n", name, name);
   printf_filtered ("(Note leading single quote.)\n");
}

is still needed.  I'm not worried either way but if it is, I'll change 
it and its calls a little.

enjoy,
Andrew

Re: linespec.c:cplusplus_hint()?

[Daniel Jacobowitz]

On Wed, Jan 30, 2002 at 11:34:58PM -0500, Andrew Cagney wrote:
> Hello,
> 
> I'm wondering if the function:
> 
> /* While the C++ support is still in flux, issue a possibly helpful hint on
>    using the new command completion feature on single quoted demangled C++
>    symbols.  Remove when loose ends are cleaned up.   FIXME -fnf */
> 
> static void
> cplusplus_hint (char *name)
> {
>   while (*name == '\'')
>     name++;
>   printf_filtered ("Hint: try '%s<TAB> or '%s<ESC-?>\n", name, name);
>   printf_filtered ("(Note leading single quote.)\n");
> }
> 
> is still needed.  I'm not worried either way but if it is, I'll change 
> it and its calls a little.

My vote is to keep it.  Using completion on something inside single
quotes is not obvious to me.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: linespec.c:cplusplus_hint()?

[Christopher Faylor]

On Wed, Jan 30, 2002 at 11:55:44PM -0500, Daniel Jacobowitz wrote:
>On Wed, Jan 30, 2002 at 11:34:58PM -0500, Andrew Cagney wrote:
>> Hello,
>> 
>> I'm wondering if the function:
>> 
>> /* While the C++ support is still in flux, issue a possibly helpful hint on
>>    using the new command completion feature on single quoted demangled C++
>>    symbols.  Remove when loose ends are cleaned up.   FIXME -fnf */
>> 
>> static void
>> cplusplus_hint (char *name)
>> {
>>   while (*name == '\'')
>>     name++;
>>   printf_filtered ("Hint: try '%s<TAB> or '%s<ESC-?>\n", name, name);
>>   printf_filtered ("(Note leading single quote.)\n");
>> }
>> 
>> is still needed.  I'm not worried either way but if it is, I'll change 
>> it and its calls a little.
>
>My vote is to keep it.  Using completion on something inside single
>quotes is not obvious to me.

Ditto.  I think that message is what actually clued me into the fact that I could
do this.

cgf

Re: linespec.c:cplusplus_hint()?

[Andrew Cagney]

> is still needed.  I'm not worried either way but if it is, I'll change 
>>> it and its calls a little.
> 
>>
>>My vote is to keep it.  Using completion on something inside single
>>quotes is not obvious to me.
> 
> 
> Ditto.  I think that message is what actually clued me into the fact that I could
> do this.


Thanks.  Now that I know why my change caused 500 failures :-) I'll post 
a patch.

Andrew